* Re: linux-next: build failure after merge of the tty tree
[not found] <20131031184015.adc000259e9931fd0b5d5cf7@canb.auug.org.au>
@ 2013-10-31 10:35 ` Sedat Dilek
2013-10-31 13:09 ` Philippe Proulx
0 siblings, 1 reply; 6+ messages in thread
From: Sedat Dilek @ 2013-10-31 10:35 UTC (permalink / raw)
To: Stephen Rothwell, Philippe Proulx; +Cc: Greg KH, linux-next, LKML, linux-serial
On Thu, Oct 31, 2013 at 8:40 AM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi Greg,
>
> After merging the tty tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
>
> drivers/tty/serial/omap-serial.c: In function 'serial_omap_probe':
> drivers/tty/serial/omap-serial.c:1724:22: error: expected ')' before numeric constant
> drivers/tty/serial/omap-serial.c:1724:22: warning: format '%d' expects a matching 'int' argument [-Wformat]
>
> Caused by commit e5f9bf72efbc ("serial: omap: fix a few checkpatch
> warnings"). There is a missing ',' in the dev_warn() ...
>
> I have used the version of the tty tree from next-20131030 for today.
>
[ Add CC to linux-serial ML ]
Happy HelloWien and WelcomeBackStephen!
That was only checkpatch-tested, eh :-)?
@@ -1724,8 +1722,9 @@ static int serial_omap_probe(struct platform_device *pdev)
up->port.uartclk = omap_up_info->uartclk;
if (!up->port.uartclk) {
up->port.uartclk = DEFAULT_CLK_SPEED;
- dev_warn(&pdev->dev, "No clock speed specified: using default:"
- "%d\n", DEFAULT_CLK_SPEED);
+ dev_warn(&pdev->dev,
+ "No clock speed specified: using default: %d\n" <--- Comma missing here!
+ DEFAULT_CLK_SPEED);
}
- Sedat -
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: linux-next: build failure after merge of the tty tree
2013-10-31 10:35 ` linux-next: build failure after merge of the tty tree Sedat Dilek
@ 2013-10-31 13:09 ` Philippe Proulx
2013-10-31 13:24 ` Greg KH
0 siblings, 1 reply; 6+ messages in thread
From: Philippe Proulx @ 2013-10-31 13:09 UTC (permalink / raw)
To: sedat dilek; +Cc: Greg KH, linux-next, LKML, linux-serial, Stephen Rothwell
----- Original Message -----
> From: "Sedat Dilek" <sedat.dilek@gmail.com>
> To: "Stephen Rothwell" <sfr@canb.auug.org.au>, "Philippe Proulx" <philippe.proulx@savoirfairelinux.com>
> Cc: "Greg KH" <greg@kroah.com>, "linux-next" <linux-next@vger.kernel.org>, "LKML" <linux-kernel@vger.kernel.org>,
> linux-serial@vger.kernel.org
> Sent: Thursday, 31 October, 2013 6:35:23 AM
> Subject: Re: linux-next: build failure after merge of the tty tree
>
> On Thu, Oct 31, 2013 at 8:40 AM, Stephen Rothwell
> <sfr@canb.auug.org.au> wrote:
> > Hi Greg,
> >
> > After merging the tty tree, today's linux-next build (arm
> > multi_v7_defconfig) failed like this:
> >
> > drivers/tty/serial/omap-serial.c: In function 'serial_omap_probe':
> > drivers/tty/serial/omap-serial.c:1724:22: error: expected ')'
> > before numeric constant
> > drivers/tty/serial/omap-serial.c:1724:22: warning: format '%d'
> > expects a matching 'int' argument [-Wformat]
> >
> > Caused by commit e5f9bf72efbc ("serial: omap: fix a few checkpatch
> > warnings"). There is a missing ',' in the dev_warn() ...
> >
> > I have used the version of the tty tree from next-20131030 for
> > today.
> >
>
> [ Add CC to linux-serial ML ]
>
> Happy HelloWien and WelcomeBackStephen!
>
> That was only checkpatch-tested, eh :-)?
>
> @@ -1724,8 +1722,9 @@ static int serial_omap_probe(struct
> platform_device *pdev)
> up->port.uartclk = omap_up_info->uartclk;
> if (!up->port.uartclk) {
> up->port.uartclk = DEFAULT_CLK_SPEED;
> - dev_warn(&pdev->dev, "No clock speed specified: using default:"
> - "%d\n", DEFAULT_CLK_SPEED);
> + dev_warn(&pdev->dev,
> + "No clock speed specified: using default: %d\n" <--- Comma missing
> here!
Oops, something obviously went wrong in my process. Sorry about this.
Do you want me to fix this commit?
> + DEFAULT_CLK_SPEED);
> }
>
> - Sedat -
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: linux-next: build failure after merge of the tty tree
2013-10-31 13:09 ` Philippe Proulx
@ 2013-10-31 13:24 ` Greg KH
0 siblings, 0 replies; 6+ messages in thread
From: Greg KH @ 2013-10-31 13:24 UTC (permalink / raw)
To: Philippe Proulx
Cc: sedat dilek, linux-next, LKML, linux-serial, Stephen Rothwell
On Thu, Oct 31, 2013 at 09:09:51AM -0400, Philippe Proulx wrote:
> ----- Original Message -----
> > From: "Sedat Dilek" <sedat.dilek@gmail.com>
> > To: "Stephen Rothwell" <sfr@canb.auug.org.au>, "Philippe Proulx" <philippe.proulx@savoirfairelinux.com>
> > Cc: "Greg KH" <greg@kroah.com>, "linux-next" <linux-next@vger.kernel.org>, "LKML" <linux-kernel@vger.kernel.org>,
> > linux-serial@vger.kernel.org
> > Sent: Thursday, 31 October, 2013 6:35:23 AM
> > Subject: Re: linux-next: build failure after merge of the tty tree
> >
> > On Thu, Oct 31, 2013 at 8:40 AM, Stephen Rothwell
> > <sfr@canb.auug.org.au> wrote:
> > > Hi Greg,
> > >
> > > After merging the tty tree, today's linux-next build (arm
> > > multi_v7_defconfig) failed like this:
> > >
> > > drivers/tty/serial/omap-serial.c: In function 'serial_omap_probe':
> > > drivers/tty/serial/omap-serial.c:1724:22: error: expected ')'
> > > before numeric constant
> > > drivers/tty/serial/omap-serial.c:1724:22: warning: format '%d'
> > > expects a matching 'int' argument [-Wformat]
> > >
> > > Caused by commit e5f9bf72efbc ("serial: omap: fix a few checkpatch
> > > warnings"). There is a missing ',' in the dev_warn() ...
> > >
> > > I have used the version of the tty tree from next-20131030 for
> > > today.
> > >
> >
> > [ Add CC to linux-serial ML ]
> >
> > Happy HelloWien and WelcomeBackStephen!
> >
> > That was only checkpatch-tested, eh :-)?
> >
> > @@ -1724,8 +1722,9 @@ static int serial_omap_probe(struct
> > platform_device *pdev)
> > up->port.uartclk = omap_up_info->uartclk;
> > if (!up->port.uartclk) {
> > up->port.uartclk = DEFAULT_CLK_SPEED;
> > - dev_warn(&pdev->dev, "No clock speed specified: using default:"
> > - "%d\n", DEFAULT_CLK_SPEED);
> > + dev_warn(&pdev->dev,
> > + "No clock speed specified: using default: %d\n" <--- Comma missing
> > here!
>
> Oops, something obviously went wrong in my process. Sorry about this.
>
> Do you want me to fix this commit?
Please send me a patch that I can apply.
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* linux-next: build failure after merge of the tty tree
@ 2022-08-02 20:06 broonie
2022-08-02 20:27 ` Doug Anderson
0 siblings, 1 reply; 6+ messages in thread
From: broonie @ 2022-08-02 20:06 UTC (permalink / raw)
To: Greg KH, Douglas Anderson, Vijaya Krishna Nivarthi
Cc: Linux Kernel Mailing List, Linux Next Mailing List, linux-serial,
linux-arm-msm
Hi all,
After merging the tty tree, today's linux-next build (x86 allmodconfig)
failed like this:
In file included from /tmp/next/build/include/linux/device.h:15,
from /tmp/next/build/include/linux/node.h:18,
from /tmp/next/build/include/linux/cpu.h:17,
from /tmp/next/build/include/linux/of_device.h:5,
from /tmp/next/build/drivers/tty/serial/qcom_geni_serial.c:14:
/tmp/next/build/drivers/tty/serial/qcom_geni_serial.c: In function 'qcom_geni_serial_set_termios':
/tmp/next/build/drivers/tty/serial/qcom_geni_serial.c:1039:4: error: format '%lu' expects argument of type 'long unsigned int', but argument 3 has type 'unsigned int' [-Werror=format=]
1039 | "Couldn't find suitable clock rate for %lu\n",
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/tmp/next/build/include/linux/dev_printk.h:110:16: note: in definition of macro 'dev_printk_index_wrap'
110 | _p_func(dev, fmt, ##__VA_ARGS__); \
| ^~~
/tmp/next/build/include/linux/dev_printk.h:144:49: note: in expansion of macro 'dev_fmt'
144 | dev_printk_index_wrap(_dev_err, KERN_ERR, dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~
/tmp/next/build/drivers/tty/serial/qcom_geni_serial.c:1038:3: note: in expansion of macro 'dev_err'
1038 | dev_err(port->se.dev,
| ^~~~~~~
/tmp/next/build/drivers/tty/serial/qcom_geni_serial.c:1039:45: note: format string is defined here
1039 | "Couldn't find suitable clock rate for %lu\n",
| ~~^
| |
| long unsigned int
| %u
In file included from /tmp/next/build/include/linux/printk.h:573,
from /tmp/next/build/include/linux/kernel.h:29,
from /tmp/next/build/include/linux/clk.h:13,
from /tmp/next/build/drivers/tty/serial/qcom_geni_serial.c:7:
/tmp/next/build/drivers/tty/serial/qcom_geni_serial.c:1044:24: error: format '%lu' expects argument of type 'long unsigned int', but argument 4 has type 'unsigned int' [-Werror=format=]
1044 | dev_dbg(port->se.dev, "desired_rate-%lu, clk_rate-%lu, clk_div-%u\n",
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/tmp/next/build/include/linux/dynamic_debug.h:134:15: note: in definition of macro '__dynamic_func_call'
134 | func(&id, ##__VA_ARGS__); \
| ^~~~~~~~~~~
/tmp/next/build/include/linux/dynamic_debug.h:166:2: note: in expansion of macro '_dynamic_func_call'
166 | _dynamic_func_call(fmt,__dynamic_dev_dbg, \
| ^~~~~~~~~~~~~~~~~~
/tmp/next/build/include/linux/dev_printk.h:155:2: note: in expansion of macro 'dynamic_dev_dbg'
155 | dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~
/tmp/next/build/include/linux/dev_printk.h:155:23: note: in expansion of macro 'dev_fmt'
155 | dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~
/tmp/next/build/drivers/tty/serial/qcom_geni_serial.c:1044:2: note: in expansion of macro 'dev_dbg'
1044 | dev_dbg(port->se.dev, "desired_rate-%lu, clk_rate-%lu, clk_div-%u\n",
| ^~~~~~~
/tmp/next/build/drivers/tty/serial/qcom_geni_serial.c:1044:40: note: format string is defined here
1044 | dev_dbg(port->se.dev, "desired_rate-%lu, clk_rate-%lu, clk_div-%u\n",
| ~~^
| |
| long unsigned int
| %u
Caused by commit
c474c775716edd46a5 ("tty: serial: qcom-geni-serial: Fix get_clk_div_rate() which otherwise could return a sub-optimal clock rate.")
I have used the tree from 20220727 instead.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: linux-next: build failure after merge of the tty tree
2022-08-02 20:06 broonie
@ 2022-08-02 20:27 ` Doug Anderson
2022-08-03 6:10 ` Greg KH
0 siblings, 1 reply; 6+ messages in thread
From: Doug Anderson @ 2022-08-02 20:27 UTC (permalink / raw)
To: Mark Brown
Cc: Greg KH, Vijaya Krishna Nivarthi, Linux Kernel Mailing List,
Linux Next Mailing List, linux-serial, linux-arm-msm
Hi,
On Tue, Aug 2, 2022 at 1:07 PM <broonie@kernel.org> wrote:
>
> Caused by commit
>
> c474c775716edd46a5 ("tty: serial: qcom-geni-serial: Fix get_clk_div_rate() which otherwise could return a sub-optimal clock rate.")
>
> I have used the tree from 20220727 instead.
Posted a fix: ("tty: serial: qcom-geni-serial: Fix %lu -> %u in print
statements") [1]
[1] https://lore.kernel.org/r/20220802132250.1.Iea061e14157a17e114dbe2eca764568a02d6b889@changeid
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: linux-next: build failure after merge of the tty tree
2022-08-02 20:27 ` Doug Anderson
@ 2022-08-03 6:10 ` Greg KH
0 siblings, 0 replies; 6+ messages in thread
From: Greg KH @ 2022-08-03 6:10 UTC (permalink / raw)
To: Doug Anderson
Cc: Mark Brown, Vijaya Krishna Nivarthi, Linux Kernel Mailing List,
Linux Next Mailing List, linux-serial, linux-arm-msm
On Tue, Aug 02, 2022 at 01:27:25PM -0700, Doug Anderson wrote:
> Hi,
>
> On Tue, Aug 2, 2022 at 1:07 PM <broonie@kernel.org> wrote:
> >
> > Caused by commit
> >
> > c474c775716edd46a5 ("tty: serial: qcom-geni-serial: Fix get_clk_div_rate() which otherwise could return a sub-optimal clock rate.")
> >
> > I have used the tree from 20220727 instead.
>
> Posted a fix: ("tty: serial: qcom-geni-serial: Fix %lu -> %u in print
> statements") [1]
>
> [1] https://lore.kernel.org/r/20220802132250.1.Iea061e14157a17e114dbe2eca764568a02d6b889@changeid
Thanks, I'll pick it up now.
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-08-03 6:10 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20131031184015.adc000259e9931fd0b5d5cf7@canb.auug.org.au>
2013-10-31 10:35 ` linux-next: build failure after merge of the tty tree Sedat Dilek
2013-10-31 13:09 ` Philippe Proulx
2013-10-31 13:24 ` Greg KH
2022-08-02 20:06 broonie
2022-08-02 20:27 ` Doug Anderson
2022-08-03 6:10 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).