linux-serial.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Karl Dahlke <eklhad@comcast.net>
To: peter@hurleysoftware.com
Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
	linux-serial@vger.kernel.org, stable@vger.kernel.org
Subject: Bug in tty cooked mode kernel 3.12.3
Date: Mon, 09 Dec 2013 19:12:04 -0500	[thread overview]
Message-ID: <20131109191204.eklhad@comcast.net> (raw)
In-Reply-To: 1386630367-4658-1-git-send-email-peter@hurleysoftware.com

> Thanks for the report, Karl.
> 
> Please test the patch below (requires
> commit 39434abd942c8e4b9c14c06a03b3245beaf8467f,
> 'n_tty: Fix missing newline echo').
> This should fix the 'newline output after the new prompt' problem.

Hey hey - you did it!
I did my console switch, which *always* revealed the bug,
and it is not there any more.
I've also spent a couple hours in cooked mode programs, like my editor,
and the lines are all correct.
I'll keep at it for a few days, but for now I'm going to say it's fixed.
Please push this into the next release, and perhaps backport
if possible; for those of us in cooked line mode
it was really an inconvenient bug.
Finally, my complements to you.
I read the code in n_tty.c and I don't understand any of it.
It's way beyond me.
Nice job, and thank you.


Karl Dahlke

  reply	other threads:[~2013-12-10  0:13 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20131107184607.eklhad@comcast.net>
2013-12-08  5:36 ` Bug in tty cooked mode kernel 3.12.3 Greg KH
2013-12-08  6:16   ` Karl Dahlke
2013-12-08  7:18     ` Greg KH
2013-12-09 23:06 ` Peter Hurley
2013-12-10  0:12   ` Karl Dahlke [this message]
2013-12-17 17:30   ` Greg Kroah-Hartman
2013-12-17 17:46     ` Peter Hurley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131109191204.eklhad@comcast.net \
    --to=eklhad@comcast.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=peter@hurleysoftware.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).