From: One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>
To: Peter Hurley <peter@hurleysoftware.com>
Cc: Heorhi Valakhanovich <valahanovich@tut.by>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
gregkh@linuxfoundation.org
Subject: Re: [PATCH] tty: Only hangup once
Date: Mon, 18 Nov 2013 23:03:39 +0000 [thread overview]
Message-ID: <20131118230339.5402fac4@alan.etchedpixels.co.uk> (raw)
In-Reply-To: <528A5043.6030901@hurleysoftware.com>
> I doubt this is caused by a race condition; the first hangup would do most
> of the destruction regardless, and a second hangup can't really race with
> the first because of the tty_lock() held for most of the hangup.
>
> In any event, it's worth discovering what state a subsequent hangup can
> effect that the first hangup left incomplete. I'll look into it.
>
> Regards,
> Peter Hurley
disassociate_ctty races with tty_hangup.
tty->pgrp is only protected by ctrl_lock
See no_tty and the FIXME note. Sorry the FIXME wasn't clearer.
Alan
prev parent reply other threads:[~2013-11-18 23:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-31 18:05 [PATCH] tty: Only hangup once Peter Hurley
2013-08-02 3:46 ` Greg Kroah-Hartman
2013-08-02 23:02 ` Peter Hurley
2013-11-17 17:38 ` Heorhi Valakhanovich
2013-11-18 13:42 ` One Thousand Gnomes
2013-11-18 17:37 ` Peter Hurley
2013-11-18 20:32 ` Peter Hurley
2013-11-18 21:09 ` Heorhi Valakhanovich
2013-11-19 13:46 ` Peter Hurley
2013-11-19 17:19 ` Heorhi Valakhanovich
2013-11-19 17:40 ` Greg KH
2013-11-19 21:34 ` Peter Hurley
2013-11-19 23:05 ` Greg KH
2013-11-18 23:03 ` One Thousand Gnomes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131118230339.5402fac4@alan.etchedpixels.co.uk \
--to=gnomes@lxorguk.ukuu.org.uk \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=peter@hurleysoftware.com \
--cc=valahanovich@tut.by \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).