From: Mark Brown <broonie@kernel.org>
To: "Sören Brinkmann" <soren.brinkmann@xilinx.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.cz>,
linux-serial@vger.kernel.org, linaro-kernel@lists.linaro.org
Subject: Re: [PATCH] tty: xuartps: Fix build when SYSRQ is disabled
Date: Wed, 18 Dec 2013 00:02:09 +0000 [thread overview]
Message-ID: <20131218000209.GA28455@sirena.org.uk> (raw)
In-Reply-To: <3cc3bceb-93a4-4053-bbde-0aa3c2eebe1c@VA3EHSMHS043.ehs.local>
[-- Attachment #1: Type: text/plain, Size: 994 bytes --]
On Tue, Dec 17, 2013 at 03:53:14PM -0800, Sören Brinkmann wrote:
> On Tue, Dec 17, 2013 at 03:47:44PM -0800, Greg Kroah-Hartman wrote:
> > On Tue, Dec 17, 2013 at 11:27:38PM +0000, Mark Brown wrote:
> > > The sysrq field in struct uart_port is only defined when
> > > SERIAL_CORE_CONSOLE or SUPPORT_SYSRQ are selected but the driver uses
> > > the field unconditionally, causing build failures if they aren't (as
> > > happens when doing an arm64 allmodconfig). Make the usage conditional
> > > as well.
> > Is this a 3.13-final fix, or can it wait for 3.14?
> I sent out pretty much the same fix a week ago:
> https://lkml.org/lkml/2013/12/2/694
> It seems to fix a broken build for certain configurations. Hence, I'd
> say it's a fix for 3.13.
Yeah, it's a definite build fail with an obvious fix. You do have to go
looking for the issue and there's a simple workaround so it's not super
critical but it's definitely -final material until very late in the
cycle.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2013-12-18 0:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-17 23:27 [PATCH] tty: xuartps: Fix build when SYSRQ is disabled Mark Brown
2013-12-17 23:47 ` Greg Kroah-Hartman
2013-12-17 23:53 ` Sören Brinkmann
2013-12-18 0:01 ` Greg Kroah-Hartman
2013-12-18 0:02 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131218000209.GA28455@sirena.org.uk \
--to=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.cz \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-serial@vger.kernel.org \
--cc=soren.brinkmann@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).