* [PATCH] serial: omap-serial: Move info message to probe function
@ 2014-01-24 17:09 Markus Pargmann
2014-01-24 17:37 ` Tony Lindgren
2014-02-13 9:56 ` Uwe Kleine-König
0 siblings, 2 replies; 3+ messages in thread
From: Markus Pargmann @ 2014-01-24 17:09 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: linux-omap, linux-serial, kernel, Markus Pargmann, Tony Lindgren
Currently the info message about a missing wakeirq for uart is printed
every time the serial driver's startup function is called. This happens
multiple times and not just once.
This patch moves the infomessage to the probe function to display it
only once.
Cc: Tony Lindgren <tony@atomide.com>
Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
---
drivers/tty/serial/omap-serial.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/tty/serial/omap-serial.c b/drivers/tty/serial/omap-serial.c
index fa511eb..2051581 100644
--- a/drivers/tty/serial/omap-serial.c
+++ b/drivers/tty/serial/omap-serial.c
@@ -738,9 +738,6 @@ static int serial_omap_startup(struct uart_port *port)
return retval;
}
disable_irq(up->wakeirq);
- } else {
- dev_info(up->port.dev, "no wakeirq for uart%d\n",
- up->port.line);
}
dev_dbg(up->port.dev, "serial_omap_startup+%d\n", up->port.line);
@@ -1687,6 +1684,9 @@ static int serial_omap_probe(struct platform_device *pdev)
up->port.iotype = UPIO_MEM;
up->port.irq = uartirq;
up->wakeirq = wakeirq;
+ if (!up->wakeirq)
+ dev_info(up->port.dev, "no wakeirq for uart%d\n",
+ up->port.line);
up->port.regshift = 2;
up->port.fifosize = 64;
--
1.8.5.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] serial: omap-serial: Move info message to probe function
2014-01-24 17:09 [PATCH] serial: omap-serial: Move info message to probe function Markus Pargmann
@ 2014-01-24 17:37 ` Tony Lindgren
2014-02-13 9:56 ` Uwe Kleine-König
1 sibling, 0 replies; 3+ messages in thread
From: Tony Lindgren @ 2014-01-24 17:37 UTC (permalink / raw)
To: Markus Pargmann; +Cc: Greg Kroah-Hartman, linux-omap, linux-serial, kernel
* Markus Pargmann <mpa@pengutronix.de> [140124 09:12]:
> Currently the info message about a missing wakeirq for uart is printed
> every time the serial driver's startup function is called. This happens
> multiple times and not just once.
>
> This patch moves the infomessage to the probe function to display it
> only once.
Makes sense to me:
Acked-by: Tony Lindgren <tony@atomide.com>
> Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
> ---
> drivers/tty/serial/omap-serial.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/tty/serial/omap-serial.c b/drivers/tty/serial/omap-serial.c
> index fa511eb..2051581 100644
> --- a/drivers/tty/serial/omap-serial.c
> +++ b/drivers/tty/serial/omap-serial.c
> @@ -738,9 +738,6 @@ static int serial_omap_startup(struct uart_port *port)
> return retval;
> }
> disable_irq(up->wakeirq);
> - } else {
> - dev_info(up->port.dev, "no wakeirq for uart%d\n",
> - up->port.line);
> }
>
> dev_dbg(up->port.dev, "serial_omap_startup+%d\n", up->port.line);
> @@ -1687,6 +1684,9 @@ static int serial_omap_probe(struct platform_device *pdev)
> up->port.iotype = UPIO_MEM;
> up->port.irq = uartirq;
> up->wakeirq = wakeirq;
> + if (!up->wakeirq)
> + dev_info(up->port.dev, "no wakeirq for uart%d\n",
> + up->port.line);
>
> up->port.regshift = 2;
> up->port.fifosize = 64;
> --
> 1.8.5.2
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] serial: omap-serial: Move info message to probe function
2014-01-24 17:09 [PATCH] serial: omap-serial: Move info message to probe function Markus Pargmann
2014-01-24 17:37 ` Tony Lindgren
@ 2014-02-13 9:56 ` Uwe Kleine-König
1 sibling, 0 replies; 3+ messages in thread
From: Uwe Kleine-König @ 2014-02-13 9:56 UTC (permalink / raw)
To: Markus Pargmann
Cc: Greg Kroah-Hartman, linux-omap, linux-serial, kernel,
Tony Lindgren
On Fri, Jan 24, 2014 at 06:09:41PM +0100, Markus Pargmann wrote:
> Currently the info message about a missing wakeirq for uart is printed
> every time the serial driver's startup function is called. This happens
> multiple times and not just once.
>
> This patch moves the infomessage to the probe function to display it
> only once.
>
> Cc: Tony Lindgren <tony@atomide.com>
> Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> drivers/tty/serial/omap-serial.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/tty/serial/omap-serial.c b/drivers/tty/serial/omap-serial.c
> index fa511eb..2051581 100644
> --- a/drivers/tty/serial/omap-serial.c
> +++ b/drivers/tty/serial/omap-serial.c
> @@ -738,9 +738,6 @@ static int serial_omap_startup(struct uart_port *port)
> return retval;
> }
> disable_irq(up->wakeirq);
> - } else {
> - dev_info(up->port.dev, "no wakeirq for uart%d\n",
> - up->port.line);
> }
>
> dev_dbg(up->port.dev, "serial_omap_startup+%d\n", up->port.line);
> @@ -1687,6 +1684,9 @@ static int serial_omap_probe(struct platform_device *pdev)
> up->port.iotype = UPIO_MEM;
> up->port.irq = uartirq;
> up->wakeirq = wakeirq;
> + if (!up->wakeirq)
> + dev_info(up->port.dev, "no wakeirq for uart%d\n",
> + up->port.line);
>
> up->port.regshift = 2;
> up->port.fifosize = 64;
> --
> 1.8.5.2
>
>
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-02-13 9:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-24 17:09 [PATCH] serial: omap-serial: Move info message to probe function Markus Pargmann
2014-01-24 17:37 ` Tony Lindgren
2014-02-13 9:56 ` Uwe Kleine-König
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).