From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Pavel Machek <pavel@ucw.cz>
Cc: Mark Brown <broonie@kernel.org>, Tomasz Figa <t.figa@samsung.com>,
Tushar Behera <tushar.behera@linaro.org>,
Russell King - ARM Linux <linux@arm.linux.org.uk>,
lkml <linux-kernel@vger.kernel.org>,
linux-serial <linux-serial@vger.kernel.org>,
linux-samsung-soc <linux-samsung-soc@vger.kernel.org>,
jslaby <jslaby@suse.cz>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Ben Dooks <ben.dooks@codethink.co.uk>
Subject: Re: [PATCH 1/2] serial: samsung: Move uart_register_driver call to device probe
Date: Mon, 27 Jan 2014 00:04:26 +0000 [thread overview]
Message-ID: <20140127000426.6027cdd5@www.etchedpixels.co.uk> (raw)
In-Reply-To: <20140126210907.GB7246@Nokia-N900>
On Sun, 26 Jan 2014 22:09:07 +0100
Pavel Machek <pavel@ucw.cz> wrote:
> On Thu 2014-01-23 19:36:33, Mark Brown wrote:
> > On Thu, Jan 23, 2014 at 07:47:56PM +0100, Tomasz Figa wrote:
> > > On 23.01.2014 19:40, Mark Brown wrote:
> >
> > > >We'd need to leave it user selectable rather than enabling it for ARM,
> > > >the whole reason this got noticed is that people are trying to build
> > > >kernels that support a wider range of devices for ARM.
> >
> > > What about making it depend on !MULTIPLATFORM and enabled by default?
> >
> > That'd work, but if we're doing that then substituting in the dynamic
> > assignment only when we hit a collision seems smoother and more general.
>
> That seems like a mess. I had enough fun debugging "WTF is
> going on with my serials" as is...
>
> Plus... collision can happen at runtime when you insert
> BT CF card... at that point it is too late to reassign.
Agreed entirely - you want predictability here, plus making it happen by
magic is going to do the nut of anyone trying to figure out why kernel A
works on their platform and kernel B doesn't.
It needs to be something you choose to turn on as compatibility, like old
sysfs files and so forth.
next prev parent reply other threads:[~2014-01-27 0:05 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-20 9:02 [PATCH 0/2] serial: Move uart_register_driver call to device probe Tushar Behera
2014-01-20 9:02 ` [PATCH 1/2] serial: samsung: " Tushar Behera
2014-01-20 10:05 ` Russell King - ARM Linux
2014-01-20 11:53 ` Tushar Behera
2014-01-20 12:26 ` Russell King - ARM Linux
2014-01-20 21:43 ` Alan Cox
2014-01-20 23:14 ` Mark Brown
2014-01-20 23:21 ` Russell King - ARM Linux
2014-01-20 23:35 ` Alan Cox
2014-01-20 23:52 ` Greg Kroah-Hartman
2014-01-20 23:47 ` Alan Cox
2014-01-21 0:16 ` Russell King - ARM Linux
2014-01-21 9:03 ` Alan Cox
2014-01-21 9:49 ` Russell King - ARM Linux
[not found] ` <50b66ac6-1150-4ad7-aeaf-3d0dce77334d@email.android.com>
2014-01-26 11:54 ` Russell King - ARM Linux
2014-01-27 4:30 ` Nicolas Pitre
2014-01-27 10:07 ` Alan Cox
2014-01-27 12:32 ` Russell King - ARM Linux
2014-01-27 15:03 ` Nicolas Pitre
2014-01-21 16:59 ` Mark Brown
2014-01-21 18:30 ` Russell King - ARM Linux
2014-01-23 18:04 ` Alan Cox
2014-01-23 18:40 ` Mark Brown
2014-01-23 18:47 ` Tomasz Figa
2014-01-23 19:36 ` Mark Brown
2014-01-23 19:51 ` Alan Cox
2014-01-23 20:05 ` Mark Brown
2014-01-23 21:33 ` Alan Cox
2014-01-24 12:03 ` Mark Brown
2014-01-24 14:38 ` Alan Cox
2014-01-27 0:15 ` Mark Brown
2014-01-26 21:09 ` Pavel Machek
2014-01-27 0:04 ` Alan Cox [this message]
2014-01-20 21:16 ` Greg KH
2014-01-20 21:32 ` Russell King - ARM Linux
2014-01-20 23:11 ` Greg KH
2014-01-20 23:16 ` Russell King - ARM Linux
2014-01-20 23:51 ` Greg KH
2014-01-21 0:07 ` Russell King - ARM Linux
2014-01-21 0:26 ` Greg KH
2014-01-21 0:38 ` Russell King - ARM Linux
2014-01-21 9:25 ` One Thousand Gnomes
2014-01-21 9:45 ` Russell King - ARM Linux
2014-01-20 9:02 ` [PATCH 2/2] serial: pl011: " Tushar Behera
2014-01-20 10:04 ` Russell King - ARM Linux
2014-02-13 18:12 ` Greg KH
2014-02-13 18:15 ` Russell King - ARM Linux
2014-02-13 18:27 ` Greg KH
2014-02-13 18:42 ` Russell King - ARM Linux
2014-02-13 23:26 ` Greg KH
2014-02-14 0:07 ` Russell King - ARM Linux
2014-02-14 0:14 ` Greg KH
2014-02-14 0:38 ` Russell King - ARM Linux
2014-02-17 15:35 ` One Thousand Gnomes
2014-02-17 15:54 ` One Thousand Gnomes
2014-02-17 23:50 ` Mark Brown
2014-02-18 10:09 ` Etched Pixels
2014-02-19 13:57 ` Mark Brown
2014-02-19 14:47 ` One Thousand Gnomes
2014-02-19 15:53 ` Mark Brown
2014-02-19 0:47 ` One Thousand Gnomes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140127000426.6027cdd5@www.etchedpixels.co.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=ben.dooks@codethink.co.uk \
--cc=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=pavel@ucw.cz \
--cc=t.figa@samsung.com \
--cc=tushar.behera@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).