linux-serial.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Nicolas Pitre <nicolas.pitre@linaro.org>
Cc: Alan Cox <alan@etchedpixels.co.uk>,
	Alan Cox <alan@lxorguk.ukuu.org.uk>,
	Mark Brown <broonie@kernel.org>,
	Tushar Behera <tushar.behera@linaro.org>,
	lkml <linux-kernel@vger.kernel.org>,
	linux-serial <linux-serial@vger.kernel.org>,
	linux-samsung-soc <linux-samsung-soc@vger.kernel.org>,
	jslaby <jslaby@suse.cz>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Ben Dooks <ben.dooks@codethink.co.uk>
Subject: Re: [PATCH 1/2] serial: samsung: Move uart_register_driver call to device probe
Date: Mon, 27 Jan 2014 12:32:50 +0000	[thread overview]
Message-ID: <20140127123249.GJ15937@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <alpine.LFD.2.11.1401262318350.1652@knanqh.ubzr>

On Sun, Jan 26, 2014 at 11:30:00PM -0500, Nicolas Pitre wrote:
> On Sun, 26 Jan 2014, Russell King - ARM Linux wrote:
> 
> > On Tue, Jan 21, 2014 at 12:45:05AM +0000, Alan Cox wrote:
> > > Peter handed it on. Try using git log on Documentation/devices.txt. It
> > > still gets updates.
> > > 
> > > Perhaps you'd care to stick to reality and fix the tree instead of trying
> > > to excuse the mess ?
> > 
> > Perhaps returning to reality might be advantageous rather than trying
> > to repeat statements which can't have any bearing on this - especially
> > as the git history which you're referring to only goes back to 2.6.12-rc2,
> > and this predates 2.6.12-rc2 by a long shot.
> > 
> > > More importantly certain folks need to stop abusing static numbers
> > > allocated properly. Repeating it having made a total hash of it before
> > > is dismal.
> > 
> > And if you continue these stupid accusations which have no basis at all,
> > we're going to get into a real big argument, because you are soo _wrong_
> > on that point.  I was always the one arguing /against/ the re-use of
> > existing major/minor numbers.  I was the one arguing /against/ Nicolas'
> > patches to make every serial port appear in the 4,64 ttyS namespace.
> 
> If you remember correctly, that was my attempt at making serial port 
> minor assignment to be dynamic... just like everything else is today.  
> And it seemed to me that you thought this was a good idea.

I may have thought that a dynamic space for serial devices was a good
idea, but what I was referring to above was specifically the
implementation.

Unfortunately, there's precious little public evidence of this as the
patches were never posted to a public mailing list.  However, what there
is (as part of another thread) shows that I held that view:

http://archive.arm.linux.org.uk/lurker/message/20041124.164950.92dc25d7.en.html

Plus, of course, the comments in the patch system where I picked out a
number of further technical issues, such as changing inode->i_rdev,
userspace locking, etc.

If you want to review them, they're 1427/1 - 1434/1, 1435/2, 1436/2.
Unfortunately the authorship of those comments was lost.

Hence, my recollection is correct here.

-- 
FTTC broadband for 0.8mile line: 5.8Mbps down 500kbps up.  Estimation
in database were 13.1 to 19Mbit for a good line, about 7.5+ for a bad.
Estimate before purchase was "up to 13.2Mbit".

  parent reply	other threads:[~2014-01-27 12:32 UTC|newest]

Thread overview: 61+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-20  9:02 [PATCH 0/2] serial: Move uart_register_driver call to device probe Tushar Behera
2014-01-20  9:02 ` [PATCH 1/2] serial: samsung: " Tushar Behera
2014-01-20 10:05   ` Russell King - ARM Linux
2014-01-20 11:53     ` Tushar Behera
2014-01-20 12:26       ` Russell King - ARM Linux
2014-01-20 21:43       ` Alan Cox
2014-01-20 23:14         ` Mark Brown
2014-01-20 23:21           ` Russell King - ARM Linux
2014-01-20 23:35             ` Alan Cox
2014-01-20 23:52               ` Greg Kroah-Hartman
2014-01-20 23:47           ` Alan Cox
2014-01-21  0:16             ` Russell King - ARM Linux
2014-01-21  9:03               ` Alan Cox
2014-01-21  9:49                 ` Russell King - ARM Linux
     [not found]               ` <50b66ac6-1150-4ad7-aeaf-3d0dce77334d@email.android.com>
2014-01-26 11:54                 ` Russell King - ARM Linux
2014-01-27  4:30                   ` Nicolas Pitre
2014-01-27 10:07                     ` Alan Cox
2014-01-27 12:32                     ` Russell King - ARM Linux [this message]
2014-01-27 15:03                       ` Nicolas Pitre
2014-01-21 16:59             ` Mark Brown
2014-01-21 18:30               ` Russell King - ARM Linux
2014-01-23 18:04       ` Alan Cox
2014-01-23 18:40         ` Mark Brown
2014-01-23 18:47           ` Tomasz Figa
2014-01-23 19:36             ` Mark Brown
2014-01-23 19:51               ` Alan Cox
2014-01-23 20:05                 ` Mark Brown
2014-01-23 21:33                   ` Alan Cox
2014-01-24 12:03                     ` Mark Brown
2014-01-24 14:38                       ` Alan Cox
2014-01-27  0:15                         ` Mark Brown
2014-01-26 21:09               ` Pavel Machek
2014-01-27  0:04                 ` Alan Cox
2014-01-20 21:16     ` Greg KH
2014-01-20 21:32       ` Russell King - ARM Linux
2014-01-20 23:11         ` Greg KH
2014-01-20 23:16           ` Russell King - ARM Linux
2014-01-20 23:51             ` Greg KH
2014-01-21  0:07               ` Russell King - ARM Linux
2014-01-21  0:26                 ` Greg KH
2014-01-21  0:38                   ` Russell King - ARM Linux
2014-01-21  9:25                     ` One Thousand Gnomes
2014-01-21  9:45                       ` Russell King - ARM Linux
2014-01-20  9:02 ` [PATCH 2/2] serial: pl011: " Tushar Behera
2014-01-20 10:04   ` Russell King - ARM Linux
2014-02-13 18:12     ` Greg KH
2014-02-13 18:15       ` Russell King - ARM Linux
2014-02-13 18:27         ` Greg KH
2014-02-13 18:42           ` Russell King - ARM Linux
2014-02-13 23:26             ` Greg KH
2014-02-14  0:07               ` Russell King - ARM Linux
2014-02-14  0:14                 ` Greg KH
2014-02-14  0:38                   ` Russell King - ARM Linux
2014-02-17 15:35                     ` One Thousand Gnomes
2014-02-17 15:54                       ` One Thousand Gnomes
2014-02-17 23:50                       ` Mark Brown
2014-02-18 10:09                         ` Etched Pixels
2014-02-19 13:57                           ` Mark Brown
2014-02-19 14:47                             ` One Thousand Gnomes
2014-02-19 15:53                               ` Mark Brown
2014-02-19  0:47                   ` One Thousand Gnomes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140127123249.GJ15937@n2100.arm.linux.org.uk \
    --to=linux@arm.linux.org.uk \
    --cc=alan@etchedpixels.co.uk \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=ben.dooks@codethink.co.uk \
    --cc=broonie@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jslaby@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=nicolas.pitre@linaro.org \
    --cc=tushar.behera@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).