[RFC PATCH] serial: omap: only inform once about missing wakeirq support

[RFC PATCH] serial: omap: only inform once about missing wakeirq support

[Uwe Kleine-König]

The unconditional output in serial_omap_startup clutters dmesg quite a
bit when booting with systemd because the console device is opened
repeatedly.

Without this patch, directly after boot + login I get:

	# dmesg | grep -c 'omap_uart 48024000.serial: no wakeirq for uart2'
	79

This was introduced in commit 2a0b965cfb6e (serial: omap: Add support
for optional wake-up) which was applied for v3.13-rc1.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
Hello,

actually this change is not optimal because it would be nicer to report
once per device instead of not once per driver. But adding a variable to
driver data just for that seems overkill, too. Maybe downgrading the
message to dev_dbg is fine, too?

What do you think?

Best regards
Uwe

 drivers/tty/serial/omap-serial.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/drivers/tty/serial/omap-serial.c b/drivers/tty/serial/omap-serial.c
index 2116e76b9559..bbcd95360553 100644
--- a/drivers/tty/serial/omap-serial.c
+++ b/drivers/tty/serial/omap-serial.c
@@ -739,8 +739,13 @@ static int serial_omap_startup(struct uart_port *port)
 		}
 		disable_irq(up->wakeirq);
 	} else {
-		dev_info(up->port.dev, "no wakeirq for uart%d\n",
-			 up->port.line);
+		static int once = 1;
+
+		if (once) {
+			dev_info(up->port.dev, "no wakeirq for uart%d\n",
+				 up->port.line);
+			once = 0;
+		}
 	}
 
 	dev_dbg(up->port.dev, "serial_omap_startup+%d\n", up->port.line);
-- 
1.8.5.3

--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [RFC PATCH] serial: omap: only inform once about missing wakeirq support

[Markus Pargmann]

Hi,

On Thu, Feb 13, 2014 at 10:25:10AM +0100, Uwe Kleine-König wrote:
> The unconditional output in serial_omap_startup clutters dmesg quite a
> bit when booting with systemd because the console device is opened
> repeatedly.
> 
> Without this patch, directly after boot + login I get:
> 
> 	# dmesg | grep -c 'omap_uart 48024000.serial: no wakeirq for uart2'
> 	79
> 
> This was introduced in commit 2a0b965cfb6e (serial: omap: Add support
> for optional wake-up) which was applied for v3.13-rc1.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

I sent a similar patch, that moves the info message to the probe
function [1].

Regards

Markus

[1]
Message-Id: <1390583381-9076-1-git-send-email-mpa@pengutronix.de>
http://thread.gmane.org/gmane.linux.ports.arm.omap/110058

> ---
> Hello,
> 
> actually this change is not optimal because it would be nicer to report
> once per device instead of not once per driver. But adding a variable to
> driver data just for that seems overkill, too. Maybe downgrading the
> message to dev_dbg is fine, too?
> 
> What do you think?
> 
> Best regards
> Uwe
> 
>  drivers/tty/serial/omap-serial.c | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/tty/serial/omap-serial.c b/drivers/tty/serial/omap-serial.c
> index 2116e76b9559..bbcd95360553 100644
> --- a/drivers/tty/serial/omap-serial.c
> +++ b/drivers/tty/serial/omap-serial.c
> @@ -739,8 +739,13 @@ static int serial_omap_startup(struct uart_port *port)
>  		}
>  		disable_irq(up->wakeirq);
>  	} else {
> -		dev_info(up->port.dev, "no wakeirq for uart%d\n",
> -			 up->port.line);
> +		static int once = 1;
> +
> +		if (once) {
> +			dev_info(up->port.dev, "no wakeirq for uart%d\n",
> +				 up->port.line);
> +			once = 0;
> +		}
>  	}
>  
>  	dev_dbg(up->port.dev, "serial_omap_startup+%d\n", up->port.line);
> -- 
> 1.8.5.3
> 
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [RFC PATCH] serial: omap: only inform once about missing wakeirq support

[Uwe Kleine-König]

Hi Markus,

On Thu, Feb 13, 2014 at 10:47:11AM +0100, Markus Pargmann wrote:
> On Thu, Feb 13, 2014 at 10:25:10AM +0100, Uwe Kleine-König wrote:
> > The unconditional output in serial_omap_startup clutters dmesg quite a
> > bit when booting with systemd because the console device is opened
> > repeatedly.
> > 
> > Without this patch, directly after boot + login I get:
> > 
> > 	# dmesg | grep -c 'omap_uart 48024000.serial: no wakeirq for uart2'
> > 	79
> > 
> > This was introduced in commit 2a0b965cfb6e (serial: omap: Add support
> > for optional wake-up) which was applied for v3.13-rc1.
> > 
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> 
> I sent a similar patch, that moves the info message to the probe
> function [1].
That looks better. I just acked your patch and so please disregard mine.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html