From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Markus Pargmann <mpa@pengutronix.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Tony Lindgren <tony@atomide.com>,
linux-serial@vger.kernel.org, kernel@pengutronix.de,
Roger Quadros <rogerq@ti.com>, Felipe Balbi <balbi@ti.com>,
Linus Walleij <linus.walleij@linaro.org>,
Kevin Hilman <khilman@linaro.org>
Subject: Re: [RFC PATCH] serial: omap: only inform once about missing wakeirq support
Date: Thu, 13 Feb 2014 10:57:25 +0100 [thread overview]
Message-ID: <20140213095725.GB17650@pengutronix.de> (raw)
In-Reply-To: <20140213094711.GG31787@pengutronix.de>
Hi Markus,
On Thu, Feb 13, 2014 at 10:47:11AM +0100, Markus Pargmann wrote:
> On Thu, Feb 13, 2014 at 10:25:10AM +0100, Uwe Kleine-König wrote:
> > The unconditional output in serial_omap_startup clutters dmesg quite a
> > bit when booting with systemd because the console device is opened
> > repeatedly.
> >
> > Without this patch, directly after boot + login I get:
> >
> > # dmesg | grep -c 'omap_uart 48024000.serial: no wakeirq for uart2'
> > 79
> >
> > This was introduced in commit 2a0b965cfb6e (serial: omap: Add support
> > for optional wake-up) which was applied for v3.13-rc1.
> >
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>
> I sent a similar patch, that moves the info message to the probe
> function [1].
That looks better. I just acked your patch and so please disregard mine.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2014-02-13 9:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-13 9:25 [RFC PATCH] serial: omap: only inform once about missing wakeirq support Uwe Kleine-König
2014-02-13 9:47 ` Markus Pargmann
2014-02-13 9:57 ` Uwe Kleine-König [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140213095725.GB17650@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=balbi@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel@pengutronix.de \
--cc=khilman@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-serial@vger.kernel.org \
--cc=mpa@pengutronix.de \
--cc=rogerq@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).