From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Cc: linux-sh@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-serial@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 01/19] serial: sh-sci: Enable the driver on all ARM platforms
Date: Wed, 19 Feb 2014 21:54:46 +0100 [thread overview]
Message-ID: <20140219205446.GD6988@pengutronix.de> (raw)
In-Reply-To: <1383086274-11049-2-git-send-email-laurent.pinchart+renesas@ideasonboard.com>
On Tue, Oct 29, 2013 at 11:37:36PM +0100, Laurent Pinchart wrote:
> Renesas ARM platforms are transitioning from single-platform to
> multi-platform kernels using the new ARCH_SHMOBILE_MULTI. Make the
> driver available on all ARM platforms to enable it on both ARCH_SHMOBILE
> and ARCH_SHMOBILE_MULTI, and increase build testing coverage with
> COMPILE_TEST.
>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: linux-serial@vger.kernel.org
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> ---
> drivers/tty/serial/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
> index febd45c..9a5a8ef 100644
> --- a/drivers/tty/serial/Kconfig
> +++ b/drivers/tty/serial/Kconfig
> @@ -709,7 +709,7 @@ config SERIAL_IP22_ZILOG_CONSOLE
>
> config SERIAL_SH_SCI
> tristate "SuperH SCI(F) serial port support"
> - depends on HAVE_CLK && (SUPERH || ARCH_SHMOBILE)
> + depends on HAVE_CLK && (SUPERH || ARM || COMPILE_TEST)
> select SERIAL_CORE
This patch is in mainline as d4f9e7b3d12e92ede642f6f4fc7d959f06da8ccc
since v3.13-rc1. I wonder if
depends on HAVE_CLK && (SUPERH || ARCH_SHMOBILE || COMPILE_TEST)
isn't the better option. (Since bf98c1eac1d4a6bcf00532e4fa41d8126cd6c187
ARCH_SHMOBILE is enabled for both multi-platform and legacy shmobile
configs.) Or do you plan to deprecate ARCH_SHMOBILE?
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2014-02-19 20:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-29 22:37 [PATCH v2 00/19] Enable various Renesas drivers on all ARM platforms Laurent Pinchart
2013-10-29 22:37 ` [PATCH v2 01/19] serial: sh-sci: Enable the driver " Laurent Pinchart
2014-02-19 20:54 ` Uwe Kleine-König [this message]
2014-02-19 22:24 ` Laurent Pinchart
2014-02-20 0:00 ` Uwe Kleine-König
2013-10-31 5:52 ` [PATCH v2 00/19] Enable various Renesas drivers " Simon Horman
[not found] ` <1383086274-11049-1-git-send-email-laurent.pinchart+renesas-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>
2013-11-12 23:32 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140219205446.GD6988@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=gregkh@linuxfoundation.org \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).