From: Greg KH <gregkh@linuxfoundation.org>
To: jon@ringle.org
Cc: jslaby@suse.cz, linux-kernel@vger.kernel.org,
linux-serial@vger.kernel.org, Jon Ringle <jringle@gridpoint.com>
Subject: Re: [PATCH] RFC: WIP: sc16is7xx.c
Date: Thu, 6 Mar 2014 21:52:31 -0800 [thread overview]
Message-ID: <20140307055231.GA32019@kroah.com> (raw)
In-Reply-To: <1394159746-1729-1-git-send-email-jon@ringle.org>
On Thu, Mar 06, 2014 at 09:35:46PM -0500, jon@ringle.org wrote:
> From: Jon Ringle <jringle@gridpoint.com>
>
> I am requesting comments on this serial driver.
> I am currently having some latency issues with it where I experience
> packet loss at speed of 19200.
>
> I welcome any and all comments.
The basic coding style problems make it hard to read to be able to help
review it, sorry.
Yes, brains have patterns, you want to follow the same patterns as
others, it matters.
thanks,
greg k-h
next prev parent reply other threads:[~2014-03-07 5:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-07 2:35 [PATCH] RFC: WIP: sc16is7xx.c jon
2014-03-07 5:52 ` Greg KH [this message]
2014-03-07 6:26 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140307055231.GA32019@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=jon@ringle.org \
--cc=jringle@gridpoint.com \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).