From: One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>
To: Soren Brinkmann <soren.brinkmann@xilinx.com>
Cc: Russell King <linux@arm.linux.org.uk>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.cz>, Arnd Bergmann <arnd@arndb.de>,
Michal Simek <michal.simek@xilinx.com>,
Peter Crosthwaite <peter.crosthwaite@xilinx.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-serial@vger.kernel.org
Subject: Re: [PATCH RFC v2 04/11] tty: xuartps: Remove bogus comment and register write
Date: Fri, 7 Mar 2014 21:28:16 +0000 [thread overview]
Message-ID: <20140307212816.715e5e19@alan.etchedpixels.co.uk> (raw)
In-Reply-To: <1394219614-3197-5-git-send-email-soren.brinkmann@xilinx.com>
On Fri, 7 Mar 2014 11:13:27 -0800
Soren Brinkmann <soren.brinkmann@xilinx.com> wrote:
> Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com>
> ---
> drivers/tty/serial/xilinx_uartps.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c
> index a4bd6242e72d..a39c2d290902 100644
> --- a/drivers/tty/serial/xilinx_uartps.c
> +++ b/drivers/tty/serial/xilinx_uartps.c
> @@ -1082,11 +1082,7 @@ static void xuartps_console_write(struct console *co, const char *s,
>
> xuartps_writel(ctrl, XUARTPS_CR_OFFSET);
>
> - /* restore interrupt state, it seems like there may be a h/w bug
> - * in that the interrupt enable register should not need to be
> - * written based on the data sheet
> - */
> - xuartps_writel(~imr, XUARTPS_IDR_OFFSET);
> + /* restore interrupt state */
It would be appropriate for the changelog at least to explain why the
note about the data sheet differing is going away !
next prev parent reply other threads:[~2014-03-07 21:29 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-07 19:13 [PATCH RFC v2 00/11] tty: xuartps: Rebranding Soren Brinkmann
2014-03-07 19:13 ` [PATCH RFC v2 01/11] tty: xuartps: Clean up Soren Brinkmann
2014-03-07 19:13 ` [PATCH RFC v2 02/11] tty: xuartps: Print warning in clock notifier Soren Brinkmann
2014-03-07 19:13 ` [PATCH RFC v2 03/11] tty: xuartps: Refactor read-modify-writes Soren Brinkmann
2014-03-07 19:13 ` [PATCH RFC v2 04/11] tty: xuartps: Remove bogus comment and register write Soren Brinkmann
2014-03-07 21:28 ` One Thousand Gnomes [this message]
2014-03-07 23:08 ` Sören Brinkmann
2014-03-08 21:57 ` One Thousand Gnomes
2014-03-07 19:13 ` [PATCH RFC v2 05/11] tty: xuartps: Rebrand driver as Cadence UART Soren Brinkmann
2014-03-07 19:13 ` [PATCH RFC v2 06/11] tty: xuartps: Change driver name to 'cdns-uart' Soren Brinkmann
2014-03-07 21:29 ` One Thousand Gnomes
2014-03-07 22:58 ` Sören Brinkmann
2014-03-07 19:13 ` [PATCH RFC v2 07/11] tty: xuartps: Replace function and symbol prefix Soren Brinkmann
2014-03-07 23:53 ` Sören Brinkmann
2014-03-07 19:13 ` [PATCH RFC v2 08/11] tty: xuartps: Rename Kconfig symbols Soren Brinkmann
2014-03-07 21:30 ` One Thousand Gnomes
2014-03-07 22:59 ` Sören Brinkmann
2014-03-07 19:13 ` [PATCH RFC v2 09/11] ARM: multi_v7_defconfig: Adopt to UART driver renaming Soren Brinkmann
2014-03-07 23:16 ` Sören Brinkmann
2014-03-07 19:13 ` [PATCH RFC v2 10/11] tty: cadence: Document DT binding Soren Brinkmann
2014-03-08 19:34 ` Rob Herring
2014-03-07 19:13 ` [PATCH RFC v2 11/11] ARM: zynq: DT: Migrate UART to Cadence binding Soren Brinkmann
2014-03-08 19:35 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140307212816.715e5e19@alan.etchedpixels.co.uk \
--to=gnomes@lxorguk.ukuu.org.uk \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.cz \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=michal.simek@xilinx.com \
--cc=peter.crosthwaite@xilinx.com \
--cc=soren.brinkmann@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).