From mboxrd@z Thu Jan 1 00:00:00 1970 From: One Thousand Gnomes Subject: Re: [PATCH RFC v2 04/11] tty: xuartps: Remove bogus comment and register write Date: Fri, 7 Mar 2014 21:28:16 +0000 Message-ID: <20140307212816.715e5e19@alan.etchedpixels.co.uk> References: <1394219614-3197-1-git-send-email-soren.brinkmann@xilinx.com> <1394219614-3197-5-git-send-email-soren.brinkmann@xilinx.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: Received: from lxorguk.ukuu.org.uk ([81.2.110.251]:55971 "EHLO lxorguk.ukuu.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752238AbaCGV3M (ORCPT ); Fri, 7 Mar 2014 16:29:12 -0500 In-Reply-To: <1394219614-3197-5-git-send-email-soren.brinkmann@xilinx.com> Sender: linux-serial-owner@vger.kernel.org List-Id: linux-serial@vger.kernel.org To: Soren Brinkmann Cc: Russell King , Greg Kroah-Hartman , Jiri Slaby , Arnd Bergmann , Michal Simek , Peter Crosthwaite , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-serial@vger.kernel.org On Fri, 7 Mar 2014 11:13:27 -0800 Soren Brinkmann wrote: > Signed-off-by: Soren Brinkmann > --- > drivers/tty/serial/xilinx_uartps.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c > index a4bd6242e72d..a39c2d290902 100644 > --- a/drivers/tty/serial/xilinx_uartps.c > +++ b/drivers/tty/serial/xilinx_uartps.c > @@ -1082,11 +1082,7 @@ static void xuartps_console_write(struct console *co, const char *s, > > xuartps_writel(ctrl, XUARTPS_CR_OFFSET); > > - /* restore interrupt state, it seems like there may be a h/w bug > - * in that the interrupt enable register should not need to be > - * written based on the data sheet > - */ > - xuartps_writel(~imr, XUARTPS_IDR_OFFSET); > + /* restore interrupt state */ It would be appropriate for the changelog at least to explain why the note about the data sheet differing is going away !