From: Greg KH <gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>
To: Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org>
Cc: Peter Hurley
<peter-WaGBZJeGNqdsbIuE7sb01tBPR1lH4CV8@public.gmane.org>,
Alan Cox <alan-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
Marcel Holtmann <marcel-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org>,
Muralidharan Karicheri
<m-karicheri2-l0cyMroinI0@public.gmane.org>,
linux-bluetooth-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Linux Kernel Mailing List
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Huang Shijie <b32955-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
Subject: Re: hci_ldsic nested locking problem
Date: Thu, 20 Mar 2014 11:45:44 -0700 [thread overview]
Message-ID: <20140320184544.GA1113@kroah.com> (raw)
In-Reply-To: <20140320173518.GD2827-HgARHv6XitL9zxVx7UNMDg@public.gmane.org>
On Thu, Mar 20, 2014 at 12:35:18PM -0500, Felipe Balbi wrote:
> On Thu, Mar 20, 2014 at 01:34:57PM -0400, Peter Hurley wrote:
> > [ +cc Huang Shijie ]
> >
> > On 03/20/2014 01:29 PM, Felipe Balbi wrote:
> > >then we need updates to Documentation:
> > >
> > >Documentation/serial/tty.txt::
> > >
> > >| Driver Side Interfaces:
> > >|
> > >| receive_buf() - Hand buffers of bytes from the driver to the ldisc
> > >| for processing. Semantics currently rather
> > >| mysterious 8(
> > >|
> > >| write_wakeup() - May be called at any point between open and close.
> > >| The TTY_DO_WRITE_WAKEUP flag indicates if a call
> > >| is needed but always races versus calls. Thus the
> > >| ldisc must be careful about setting order and to
> > >| handle unexpected calls. Must not sleep.
> > >|
> > >| The driver is forbidden from calling this directly
> > >| from the ->write call from the ldisc as the ldisc
> > >| is permitted to call the driver write method from
> > >| this function. In such a situation defer it.
> > >
> > >documentation says ldisc is allowed to call ->write() from
> > >->write_wakeup(). huh ?
> >
> > Patch submitted but never applied.
> >
> > http://www.spinics.net/lists/linux-serial/msg11144.html
>
> Thank you. For that patch:
>
> Acked-by: Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org>
Can someone resend it, this is lost in my tree for some reason...
next prev parent reply other threads:[~2014-03-20 18:45 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-20 16:34 hci_ldsic nested locking problem Felipe Balbi
[not found] ` <20140320163435.GH32692-HgARHv6XitL9zxVx7UNMDg@public.gmane.org>
2014-03-20 16:42 ` Alan Cox
[not found] ` <1395333736.22077.32.camel-wU3TRTJX3O1FGiH78xh5akvbDziVy8sZEvhb3Hwu1Ks@public.gmane.org>
2014-03-20 17:16 ` Felipe Balbi
2014-03-20 17:29 ` Felipe Balbi
2014-03-20 17:34 ` Peter Hurley
2014-03-20 17:35 ` Felipe Balbi
[not found] ` <20140320173518.GD2827-HgARHv6XitL9zxVx7UNMDg@public.gmane.org>
2014-03-20 18:45 ` Greg KH [this message]
2014-03-20 18:54 ` Peter Hurley
2014-03-20 17:31 ` Peter Hurley
[not found] ` <532B25FC.3070408-WaGBZJeGNqdsbIuE7sb01tBPR1lH4CV8@public.gmane.org>
2014-03-20 18:11 ` Felipe Balbi
2014-03-20 18:21 ` Peter Hurley
2014-03-20 18:25 ` Felipe Balbi
2014-03-20 19:01 ` Felipe Balbi
2014-03-20 19:03 ` Felipe Balbi
2014-03-20 19:16 ` Peter Hurley
2014-03-20 19:25 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140320184544.GA1113@kroah.com \
--to=gregkh-hqyy1w1ycw8ekmwlsbkhg0b+6bgklq7r@public.gmane.org \
--cc=alan-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
--cc=b32955-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
--cc=balbi-l0cyMroinI0@public.gmane.org \
--cc=linux-bluetooth-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=m-karicheri2-l0cyMroinI0@public.gmane.org \
--cc=marcel-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org \
--cc=peter-WaGBZJeGNqdsbIuE7sb01tBPR1lH4CV8@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).