From mboxrd@z Thu Jan 1 00:00:00 1970 From: Catalin Marinas Subject: Re: [PATCH 7/8] tty/serial: add arm64 semihosting earlycon Date: Mon, 24 Mar 2014 11:38:21 +0000 Message-ID: <20140324113821.GF3850@arm.com> References: <1395436128-11244-1-git-send-email-robherring2@gmail.com> <1395436128-11244-8-git-send-email-robherring2@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from fw-tnat.austin.arm.com ([217.140.110.23]:39978 "EHLO collaborate-mta1.arm.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752454AbaCXLim (ORCPT ); Mon, 24 Mar 2014 07:38:42 -0400 Content-Disposition: inline In-Reply-To: <1395436128-11244-8-git-send-email-robherring2@gmail.com> Sender: linux-serial-owner@vger.kernel.org List-Id: linux-serial@vger.kernel.org To: Rob Herring Cc: "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-serial@vger.kernel.org" , Greg Kroah-Hartman , Jiri Slaby , Russell King , Will Deacon , "x86@kernel.org" , Arnd Bergmann , Rob Herring On Fri, Mar 21, 2014 at 09:08:47PM +0000, Rob Herring wrote: > diff --git a/Documentation/kernel-parameters.txt b/Documentation/kernel-parameters.txt > index 81bdd52..e96e2ba 100644 > --- a/Documentation/kernel-parameters.txt > +++ b/Documentation/kernel-parameters.txt > @@ -888,6 +888,7 @@ bytes respectively. Such letter suffixes can also be entirely omitted. > uart[8250],mmio,[,options] > uart[8250],mmio32,[,options] > pl011, > + smh > Start an early, polled-mode console on a serial port > at the specified I/O port or MMIO address. 8250 > MMIO inter-register address stride is either 8-bit Same comment as per a previous patch, "smh" does not take any parameters at all here. > --- /dev/null > +++ b/drivers/tty/serial/earlycon-arm-semihost.c > @@ -0,0 +1,44 @@ > +/* > + * Copyright (C) 2012 ARM Ltd. > + * Author: Catalin Marinas Nitpick: author should be Mark Zyngier as per commit 0492f72508184 (arm64: early_printk: add support for FastModel console output) -- Catalin