linux-serial.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johan Hovold <jhovold-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: "Rafał Miłecki" <zajec5-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Johan Hovold <jhovold-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Greg Kroah-Hartman
	<gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>,
	Dan Carpenter
	<dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>,
	linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Matthias Urlichs <smurf-ci3XGGwdvIcvfNposrsB4g@public.gmane.org>,
	"linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: usb_wwan regression in 3.6 kernel (bisected to bulk-urb allocation)
Date: Thu, 3 Apr 2014 09:18:19 +0200	[thread overview]
Message-ID: <20140403071819.GE22587@localhost> (raw)
In-Reply-To: <CACna6ry7WCou6kacACpQK6qhWffCGNGFyLQU8H9WbrVDLoB7Qg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

On Thu, Apr 03, 2014 at 08:49:40AM +0200, Rafał Miłecki wrote:
> I recently wanted to use my ZTE MF636 modem 19d2:0031 and got NULL
> pointer dereference in usb_wwan_write few seconds after plugging it.
> This is 100% reproducible.
> 
> BUG: unable to handle kernel NULL pointer dereference at 0000000000000058
> IP: [<ffffffffa07b9570>] usb_wwan_write+0xa0/0x2b0 [usb_wwan]
> 
> I've bisected between 3.4 and 3.14 kernels and it has appeared to be a
> regression caused by:
> 
> commit 8e493ca1767d4951ed1322abaa74d6edbca29918
> Author: Johan Hovold <jhovold-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> Date: Fri Oct 26 18:44:20 2012 +0200
> 
>     USB: usb_wwan: fix bulk-urb allocation
> 
>     Make sure we do not allocate urbs if we do not have a bulk endpoint.
> 
>     Legacy code used incorrect assumption to test for bulk endpoints.
> 
> Reverting above patch from the 3.14 release fixes the NULL pointer
> dereference for me.
> 
> Could you look into this, please? I can test any debug/fix patches you provide.

Thanks for the detailed report. Could you also provide the output of

	lsusb -vd 19d2:0031

Thanks,
Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2014-04-03  7:18 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-03  6:49 usb_wwan regression in 3.6 kernel (bisected to bulk-urb allocation) Rafał Miłecki
     [not found] ` <CACna6ry7WCou6kacACpQK6qhWffCGNGFyLQU8H9WbrVDLoB7Qg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-04-03  7:18   ` Johan Hovold [this message]
2014-04-03  7:23     ` Rafał Miłecki
     [not found]       ` <CACna6rzgnU_=2Gg4v1xk3-KX+zx6G85NksoJiZvbzGyzf+GQ_g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-04-03  8:03         ` Bjørn Mork
     [not found]           ` <87wqf696wx.fsf-lbf33ChDnrE/G1V5fR+Y7Q@public.gmane.org>
2014-04-03 10:17             ` Johan Hovold
2014-04-03 11:06               ` [PATCH] USB: usb_wwan: fix handling of missing bulk endpoints Johan Hovold
2014-04-03 11:32                 ` Rafał Miłecki
2014-04-03 14:21                   ` Johan Hovold
2014-04-03 15:20                 ` Rafał Miłecki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140403071819.GE22587@localhost \
    --to=jhovold-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
    --cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \
    --cc=linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=smurf-ci3XGGwdvIcvfNposrsB4g@public.gmane.org \
    --cc=zajec5-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).