Re: [PATCH] USB: usb_wwan: fix handling of missing bulk endpoints

[Johan Hovold <jhovold@gmail.com>]

On Thu, Apr 03, 2014 at 01:32:19PM +0200, Rafał Miłecki wrote:
> 2014-04-03 13:06 GMT+02:00 Johan Hovold <jhovold@gmail.com>:
> > Fix regression introduced by commit 8e493ca1767d ("USB: usb_wwan: fix
> > bulk-urb allocation") by making sure to require both bulk-in and out
> > endpoints during port probe.
> 
> Ohh, that was quick! :)
 
:)

> This patch works for me:
> [33050.103575] option 1-1.2:1.0: GSM modem (1-port) converter detected
> [33050.103617] [usb_wwan_port_probe] bulk_in_size:0 bulk_out_size:0
> [33050.103653] option 1-1.2:1.1: GSM modem (1-port) converter detected
> [33050.103676] [usb_wwan_port_probe] bulk_in_size:0 bulk_out_size:0
> [33050.103712] option 1-1.2:1.3: GSM modem (1-port) converter detected
> [33050.103737] [usb_wwan_port_probe] bulk_in_size:512 bulk_out_size:512
> [33050.103799] usb 1-1.2: GSM modem (1-port) converter now attached to ttyUSB2
> (out of curiosity I added one pr_info to print sizes).
> 
> Thank you!

Thanks for testing. (You can respond to the patch-submission mail with a
Tested-by tag to get some credit for that too.)

As you might have noticed the third interface still shows up as ttyUSB2
as the first two minors will still be allocated for the unusable
interfaces.

Perhaps I should add a usb_wwan_probe (that would have to be called from
every driver relying on usb_wwan) to determine whether the required
endpoints are present before binding to the interface.

But I think the current fix is the right one for stable to fix the
regression.

Johan