From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Loic Poulain <loic.poulain@intel.com>
Cc: gregkh@linuxfoundation.org, linux-serial@vger.kernel.org
Subject: Re: [PATCHv2] serial: 8250: Fix thread unsafe __dma_tx_complete function
Date: Thu, 24 Apr 2014 13:23:17 +0300 [thread overview]
Message-ID: <20140424102317.GA23665@xps8300> (raw)
In-Reply-To: <1398332088-4905-1-git-send-email-loic.poulain@intel.com>
On Thu, Apr 24, 2014 at 11:34:48AM +0200, Loic Poulain wrote:
> __dma_tx_complete is not protected against concurrent
> call of serial8250_tx_dma. it can lead to circular tail
> index corruption or parallel call of serial_tx_dma on the
> same data portion.
>
> This patch fixes this issue by holding the port lock.
>
> Signed-off-by: Loic Poulain <loic.poulain@intel.com>
I think this should also go to stable tree. It applies on top of >=v3.9.
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Thanks!
--
heikki
prev parent reply other threads:[~2014-04-24 10:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-24 9:34 [PATCHv2] serial: 8250: Fix thread unsafe __dma_tx_complete function Loic Poulain
2014-04-24 10:23 ` Heikki Krogerus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140424102317.GA23665@xps8300 \
--to=heikki.krogerus@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-serial@vger.kernel.org \
--cc=loic.poulain@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).