* [PATCH/RFC v2] serial: sh-sci: Add device tree support for r8a7779
@ 2014-04-29 7:20 Simon Horman
2014-04-30 1:06 ` Laurent Pinchart
0 siblings, 1 reply; 3+ messages in thread
From: Simon Horman @ 2014-04-29 7:20 UTC (permalink / raw)
To: Laurent Pinchart, linux-sh
Cc: Magnus Damm, linux-arm-kernel, linux-serial, Simon Horman
Simply document a new compat string.
There appears to be no need for a driver updates.
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
v2
* Do not update the driver to set SCSCR_CKE1.
Instead DT may provide the P clock as the clock for the SCIF devices.
---
Documentation/devicetree/bindings/serial/renesas,sci-serial.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/serial/renesas,sci-serial.txt b/Documentation/devicetree/bindings/serial/renesas,sci-serial.txt
index 53e6c17..bba86de 100644
--- a/Documentation/devicetree/bindings/serial/renesas,sci-serial.txt
+++ b/Documentation/devicetree/bindings/serial/renesas,sci-serial.txt
@@ -12,6 +12,7 @@ Required properties:
- "renesas,scifa-r8a7791" for R8A7791 (R-Car M2) SCIFA compatible UART.
- "renesas,scifb-r8a7791" for R8A7791 (R-Car M2) SCIFB compatible UART.
- "renesas,hscif-r8a7791" for R8A7791 (R-Car M2) HSCIF compatible UART.
+ - "renesas,scif-r8a7779" for R8A7779 (R-Car H1) SCIF compatible UART.
- "renesas,scif" for generic SCIF compatible UART.
- "renesas,scifa" for generic SCIFA compatible UART.
- "renesas,scifb" for generic SCIFB compatible UART.
--
1.8.5.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH/RFC v2] serial: sh-sci: Add device tree support for r8a7779
2014-04-29 7:20 [PATCH/RFC v2] serial: sh-sci: Add device tree support for r8a7779 Simon Horman
@ 2014-04-30 1:06 ` Laurent Pinchart
2014-04-30 1:44 ` Simon Horman
0 siblings, 1 reply; 3+ messages in thread
From: Laurent Pinchart @ 2014-04-30 1:06 UTC (permalink / raw)
To: Simon Horman
Cc: linux-sh, Magnus Damm, linux-arm-kernel, linux-serial, devicetree
Hi Simon,
Thank you for the patch.
I've CC'ed the DT list which seems to have been forgotten.
On Tuesday 29 April 2014 16:20:11 Simon Horman wrote:
> Simply document a new compat string.
> There appears to be no need for a driver updates.
>
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
>
> ---
>
> v2
> * Do not update the driver to set SCSCR_CKE1.
> Instead DT may provide the P clock as the clock for the SCIF devices.
> ---
> Documentation/devicetree/bindings/serial/renesas,sci-serial.txt | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/serial/renesas,sci-serial.txt
> b/Documentation/devicetree/bindings/serial/renesas,sci-serial.txt index
> 53e6c17..bba86de 100644
> --- a/Documentation/devicetree/bindings/serial/renesas,sci-serial.txt
> +++ b/Documentation/devicetree/bindings/serial/renesas,sci-serial.txt
> @@ -12,6 +12,7 @@ Required properties:
> - "renesas,scifa-r8a7791" for R8A7791 (R-Car M2) SCIFA compatible UART.
> - "renesas,scifb-r8a7791" for R8A7791 (R-Car M2) SCIFB compatible UART.
> - "renesas,hscif-r8a7791" for R8A7791 (R-Car M2) HSCIF compatible UART.
> + - "renesas,scif-r8a7779" for R8A7779 (R-Car H1) SCIF compatible UART.
What about moving this at the top of the list to keep it sorted by SoC number
?
Apart from that,
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> - "renesas,scif" for generic SCIF compatible UART.
> - "renesas,scifa" for generic SCIFA compatible UART.
> - "renesas,scifb" for generic SCIFB compatible UART.
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH/RFC v2] serial: sh-sci: Add device tree support for r8a7779
2014-04-30 1:06 ` Laurent Pinchart
@ 2014-04-30 1:44 ` Simon Horman
0 siblings, 0 replies; 3+ messages in thread
From: Simon Horman @ 2014-04-30 1:44 UTC (permalink / raw)
To: Laurent Pinchart
Cc: linux-sh, Magnus Damm, linux-arm-kernel, linux-serial, devicetree
On Wed, Apr 30, 2014 at 03:06:49AM +0200, Laurent Pinchart wrote:
> Hi Simon,
>
> Thank you for the patch.
>
> I've CC'ed the DT list which seems to have been forgotten.
>
> On Tuesday 29 April 2014 16:20:11 Simon Horman wrote:
> > Simply document a new compat string.
> > There appears to be no need for a driver updates.
> >
> > Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> >
> > ---
> >
> > v2
> > * Do not update the driver to set SCSCR_CKE1.
> > Instead DT may provide the P clock as the clock for the SCIF devices.
> > ---
> > Documentation/devicetree/bindings/serial/renesas,sci-serial.txt | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/Documentation/devicetree/bindings/serial/renesas,sci-serial.txt
> > b/Documentation/devicetree/bindings/serial/renesas,sci-serial.txt index
> > 53e6c17..bba86de 100644
> > --- a/Documentation/devicetree/bindings/serial/renesas,sci-serial.txt
> > +++ b/Documentation/devicetree/bindings/serial/renesas,sci-serial.txt
> > @@ -12,6 +12,7 @@ Required properties:
> > - "renesas,scifa-r8a7791" for R8A7791 (R-Car M2) SCIFA compatible UART.
> > - "renesas,scifb-r8a7791" for R8A7791 (R-Car M2) SCIFB compatible UART.
> > - "renesas,hscif-r8a7791" for R8A7791 (R-Car M2) HSCIF compatible UART.
> > + - "renesas,scif-r8a7779" for R8A7779 (R-Car H1) SCIF compatible UART.
>
> What about moving this at the top of the list to keep it sorted by SoC number
> ?
Sure, will do.
>
> Apart from that,
>
> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> > - "renesas,scif" for generic SCIF compatible UART.
> > - "renesas,scifa" for generic SCIFA compatible UART.
> > - "renesas,scifb" for generic SCIFB compatible UART.
>
> --
> Regards,
>
> Laurent Pinchart
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-04-30 1:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-29 7:20 [PATCH/RFC v2] serial: sh-sci: Add device tree support for r8a7779 Simon Horman
2014-04-30 1:06 ` Laurent Pinchart
2014-04-30 1:44 ` Simon Horman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).