Linux Serial subsystem development
 help / color / mirror / Atom feed
From: Johannes Thumshirn <johannes.thumshirn@men.de>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jiri Slaby <jslaby@suse.cz>
Cc: linux-serial@vger.kernel.org, Jun Shih <Jun.Shih@pason.com>,
	Johannes Thumshirn <johannes.thumshirn@men.de>
Subject: Re: [PATCH] tty: serial: men_z135_uart: Wakeup UART after transmitting
Date: Fri, 13 Jun 2014 08:21:38 +0200	[thread overview]
Message-ID: <20140613062137.GA15556@jtlinux> (raw)
In-Reply-To: <1402639566-15493-1-git-send-email-johannes.thumshirn@men.de>

On Fri, Jun 13, 2014 at 08:06:06AM +0200, Johannes Thumshirn wrote:
> From: Johannes Thumshirn <johanes.thumshirn@men.de>
>
> Call uart_write_wakeup() after writing the hardware FIFO and updateing the FIFO
> pointers.
>
> This fixes high latency and jitter on PPP over Serial links.
>
> Reported-by: Jun Shih <Jun.Shih@pason.com>
> Tested-by: Jun Shih <Jun.Shih@pason.com>
> Signed-off-by: Johannes Thumshirn <johannes.thumshirn@men.de>
> ---
>  drivers/tty/serial/men_z135_uart.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/tty/serial/men_z135_uart.c b/drivers/tty/serial/men_z135_uart.c
> index c9d1854..30e9e60 100644
> --- a/drivers/tty/serial/men_z135_uart.c
> +++ b/drivers/tty/serial/men_z135_uart.c
> @@ -308,9 +308,6 @@ static void men_z135_handle_tx(struct men_z135_port *uart)
>  	if (port->x_char)
>  		goto out;
>
> -	if (uart_circ_chars_pending(xmit) < WAKEUP_CHARS)
> -		uart_write_wakeup(port);
> -
>  	/* calculate bytes to copy */
>  	qlen = uart_circ_chars_pending(xmit);
>  	if (qlen <= 0)
> @@ -357,6 +354,9 @@ static void men_z135_handle_tx(struct men_z135_port *uart)
>
>  	port->icount.tx += n;
>
> +	if (uart_circ_chars_pending(xmit) < WAKEUP_CHARS)
> +		uart_write_wakeup(port);
> +
>  irq_en:
>  	if (!uart_circ_empty(xmit))
>  		men_z135_reg_set(uart, MEN_Z135_CONF_REG, MEN_Z135_IER_TXCIEN);
> --
> 1.9.1

Somehow I managed to mistype my name in my gitconifg's email filed...

Should I re-send the patch?

Johannes

  reply	other threads:[~2014-06-13  6:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-13  6:06 [PATCH] tty: serial: men_z135_uart: Wakeup UART after transmitting Johannes Thumshirn
2014-06-13  6:21 ` Johannes Thumshirn [this message]
2014-06-13 18:27   ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140613062137.GA15556@jtlinux \
    --to=johannes.thumshirn@men.de \
    --cc=Jun.Shih@pason.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jslaby@suse.cz \
    --cc=linux-serial@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox