linux-serial.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>
To: Alex Elder <elder@linaro.org>
Cc: gregkh@linuxfoundation.org, heikki.krogerus@linux.intel.com,
	david.daney@cavium.com, loic.poulain@intel.com,
	linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] serial: 8250_dw: support high baudrates if possible
Date: Sat, 28 Jun 2014 16:36:08 +0100	[thread overview]
Message-ID: <20140628163608.0c5536a9@alan.etchedpixels.co.uk> (raw)
In-Reply-To: <1403889920-1127-1-git-send-email-elder@linaro.org>

On Fri, 27 Jun 2014 12:25:20 -0500
> +		rate = 16 * max(115200U, (unsigned int)baud);
> +

This assumes an arbitarily configurable clock, which is not I think the
usual case. 
> +		/*
> +		 * Request a different clock rate if necessary, and
> +		 * record it if successful.
> +		 */
> +		if (rate != p->uartclk) {
> +			BUG_ON(!data->clk);
> +			if (!clk_set_rate(data->clk, (unsigned long)rate))
> +				p->uartclk = rate;
> +		}



  reply	other threads:[~2014-06-28 15:36 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-27 17:25 [PATCH] serial: 8250_dw: support high baudrates if possible Alex Elder
2014-06-28 15:36 ` One Thousand Gnomes [this message]
2014-06-28 20:15   ` Alex Elder
2014-07-01 22:02     ` One Thousand Gnomes
2014-07-02  0:15       ` Alex Elder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140628163608.0c5536a9@alan.etchedpixels.co.uk \
    --to=gnomes@lxorguk.ukuu.org.uk \
    --cc=david.daney@cavium.com \
    --cc=elder@linaro.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=loic.poulain@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).