Linux Serial subsystem development
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Vineet Gupta <Vineet.Gupta1@synopsys.com>
Cc: linux-serial@vger.kernel.org
Subject: Re: [PATCH] serial/arc: Fix warning with CONSOLE_POLL
Date: Fri, 11 Jul 2014 17:48:21 -0700	[thread overview]
Message-ID: <20140712004821.GB13893@kroah.com> (raw)
In-Reply-To: <1405083697-10719-1-git-send-email-vgupta@synopsys.com>

On Fri, Jul 11, 2014 at 06:31:37PM +0530, Vineet Gupta wrote:
> | drivers/tty/serial/arc_uart.c:516:2: warning: (near initialization for 'arc_serial_pops.poll_put_char') [enabled by default]
> 
> This partially undoes "serial/arc: use uart_console_write() helper" by
> restoring the prototpye of poll helper and use a different one in
> uart_console_write()
> 
> Signed-off-by: Vineet Gupta <vgupta@synopsys.com>

You forgot a "Reported-by:" line here.

I'll go add it...


  reply	other threads:[~2014-07-12  0:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <53bf1d9a.l51qTAII/GCO14wJ%fengguang.wu@intel.com>
2014-07-11 13:01 ` [PATCH] serial/arc: Fix warning with CONSOLE_POLL Vineet Gupta
2014-07-12  0:48   ` Greg KH [this message]
2014-07-12  7:45     ` Vineet Gupta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140712004821.GB13893@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=Vineet.Gupta1@synopsys.com \
    --cc=linux-serial@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox