From: Greg KH <gregkh@linuxfoundation.org>
To: Jingchang Lu <jingchang.lu@freescale.com>
Cc: linux-serial@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] tty: serial: fsl_lpuart: add 32-bit register interface support
Date: Fri, 11 Jul 2014 17:51:22 -0700 [thread overview]
Message-ID: <20140712005122.GA31974@kroah.com> (raw)
In-Reply-To: <1405057302-26041-3-git-send-email-jingchang.lu@freescale.com>
On Fri, Jul 11, 2014 at 01:41:42PM +0800, Jingchang Lu wrote:
> This add the 32-bit register version LPUART support with big-endian
> byte order.
>
> Signed-off-by: Jingchang Lu <jingchang.lu@freescale.com>
> ---
> drivers/tty/serial/fsl_lpuart.c | 653 +++++++++++++++++++++++++++++++++++++++-
> 1 file changed, 643 insertions(+), 10 deletions(-)
You didn't even test build this patch:
CC [M] drivers/tty/serial/fsl_lpuart.o
drivers/tty/serial/fsl_lpuart.c: In function ‘lpuart_suspend’:
drivers/tty/serial/fsl_lpuart.c:1856:22: error: ‘lpuart32_reg’ undeclared (first use in this function)
uart_suspend_port(&lpuart32_reg, &sport->port);
^
No quicker way to make me grumpy...
Please take some time to do this right.
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-07-12 0:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-11 5:41 [PATCH 0/2] tty: serial: fsl_lpuart: add 32-bit register support and dt-binding Jingchang Lu
2014-07-11 5:41 ` [PATCH 1/2] dt-binding: fsl-lpuart: use exact SoC revision to document binding Jingchang Lu
2014-07-11 5:41 ` [PATCH 2/2] tty: serial: fsl_lpuart: add 32-bit register interface support Jingchang Lu
2014-07-12 0:51 ` Greg KH [this message]
2014-07-14 10:16 ` Jingchang Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140712005122.GA31974@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=jingchang.lu@freescale.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).