From: Dan Carpenter <dan.carpenter@oracle.com>
To: jringle@gridpoint.com
Cc: linux-serial@vger.kernel.org
Subject: re: serial: sc16is7xx
Date: Fri, 25 Jul 2014 15:20:47 +0300 [thread overview]
Message-ID: <20140725122047.GB528@mwanda> (raw)
Hello Jon Ringle,
The patch dfeae619d781: "serial: sc16is7xx" from Apr 24, 2014, leads
to the following static checker warning:
drivers/tty/serial/sc16is7xx.c:1168 sc16is7xx_probe()
warn: 's->clk' isn't an ERR_PTR
drivers/tty/serial/sc16is7xx.c
1167 out_clk:
1168 if (!IS_ERR(s->clk))
^^^^^^^^^^^^^
This check isn't needed because we return directly but also I don't
think we ever set s->clk so it is leaked on the remove() path as well.
1169 clk_disable_unprepare(s->clk);
1170
1171 return ret;
1172 }
regards,
dan carpenter
next reply other threads:[~2014-07-25 12:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-25 12:20 Dan Carpenter [this message]
2014-07-25 16:54 ` serial: sc16is7xx Jon Ringle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140725122047.GB528@mwanda \
--to=dan.carpenter@oracle.com \
--cc=jringle@gridpoint.com \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox