From: Felipe Balbi <balbi@ti.com>
To: Belisko Marek <marek.belisko@gmail.com>
Cc: Felipe Balbi <balbi@ti.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Dr. H. Nikolaus Schaller" <hns@goldelico.com>,
Linux OMAP Mailing List <linux-omap@vger.kernel.org>,
linux-serial@vger.kernel.org
Subject: Re: DTR gpio handling removed by 985bfd54c826c0ba873ca0adfd5589263e0c6ee2
Date: Thu, 14 Aug 2014 17:58:02 -0500 [thread overview]
Message-ID: <20140814225802.GA12109@saruman.home> (raw)
In-Reply-To: <CAAfyv36aMkE5e6Bo1hy1md+Z5EjrZjP+foZTyncp5GFtnaL_sg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 895 bytes --]
Hi,
On Thu, Aug 14, 2014 at 11:04:58PM +0200, Belisko Marek wrote:
> during 3.15 release was removed by commit
> 985bfd54c826c0ba873ca0adfd5589263e0c6ee2 code which was added by
> 9574f36fb801035f6ab0fbb1b53ce2c12c17d100 by Neil Brown. We're using
> DTR gpio in gta04 device. I plan to post DT binding for DTR gpio +
> documentation and find out that Neil's code was removed by Felipe.
> Greg can you please revert mentioned commit? We're using DTR gpio in
> gta04 device. Or is there other way how to proceed? Thanks.
there are *NO* users of that in tree, if you're using it, then please
add a proper DTS for your device and figure out a way of passing DTR
gpio through DT.
Keep in mind, also, that we might be switching back to 8250 driver (see
thread from Sebastian Siewior) so you might want to look into a way of
adding *generic* gpio-based DTR handling.
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next parent reply other threads:[~2014-08-14 22:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAAfyv36aMkE5e6Bo1hy1md+Z5EjrZjP+foZTyncp5GFtnaL_sg@mail.gmail.com>
2014-08-14 22:58 ` Felipe Balbi [this message]
2014-08-15 6:08 ` DTR gpio handling removed by 985bfd54c826c0ba873ca0adfd5589263e0c6ee2 Dr. H. Nikolaus Schaller
2014-08-15 13:24 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140814225802.GA12109@saruman.home \
--to=balbi@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=hns@goldelico.com \
--cc=linux-omap@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=marek.belisko@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).