From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH 05/15] tty: serial: Add 8250-core based omap driver Date: Fri, 15 Aug 2014 15:44:47 -0700 Message-ID: <20140815224446.GF9239@atomide.com> References: <1408124563-31541-1-git-send-email-bigeasy@linutronix.de> <1408124563-31541-6-git-send-email-bigeasy@linutronix.de> <20140815210716.GE9239@atomide.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mho-03-ewr.mailhop.org ([204.13.248.66]:57897 "EHLO mho-01-ewr.mailhop.org" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751138AbaHOWoz (ORCPT ); Fri, 15 Aug 2014 18:44:55 -0400 Content-Disposition: inline In-Reply-To: <20140815210716.GE9239@atomide.com> Sender: linux-serial-owner@vger.kernel.org List-Id: linux-serial@vger.kernel.org To: Sebastian Andrzej Siewior Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, balbi@ti.com, Vinod Koul , Greg Kroah-Hartman * Tony Lindgren [140815 14:10]: > * Sebastian Andrzej Siewior [140815 10:46]: > > This patch provides a 8250-core based UART driver for the internal OMAP > > UART. The long term goal is to provide the same functionality as the > > current OMAP uart driver and DMA support. > > I tried to merge omap-serial code together with the 8250-core code. > > There should should be hardly a noticable difference. The trigger levels > > are different compared to omap-serial: > > Nice, now it mostly works for me with off-idle too :) That is as long > as I have the DMA channels commented out in the .dts file. > > And I'm still seeing an occasional hang with pstore console just > showing: > > [ 289.076538] In-band Error seen by MPU at address 0 > [ 289.076538] ------------[ cut here ]------------ > [ 289.076568] WARNING: CPU: 0 PID: 99 at drivers/bus/omap_l3_smx.c:162 omap3_l3_app_irq+0xdc/0x134() > [ 289.076599] Modules linked in: > [ 289.076599] CPU: 0 PID: 99 Comm: test-idle-off-8 Tainted: G W 3.16.0+ #510 > [ 289.076629] [] (unwind_backtrace) from [] (show_stack+0x20/0x24) > [ 289.076660] [] (show_stack) from [] (dump_stack+0x88/0xa4) > > Which most likely means there's still some glitch with the > runtime PM somewhere and registers are being accessed when > not clocked. I _think_ I did not see it when I did not have > console=ttyS2,115200 in my cmdline but was using just pstore > console. Oh and echo mem > /sys/power/state and then hitting a key on the serial console won't wake the system. Does that need to be manually configured for device_may_wakeup()? > > The device name is ttyS based instead of ttyO. If a ttyO based node name > > is required please ask udev for it. If both driver are activated (this > > and omap-serial) then this serial driver will take control over the > > device due to the link order > > That's still not going to help with the existing kernel cmdlines > and existing installs.. I wonder if we can just do a minimal > dummy serial-omap.c that just proxies all the ttyO read/write > access to ttyS? > > Regards, > > Tony > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/