From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH 3/3] sparc/uapi: Add definition of TIOC[SG]RS485 Date: Tue, 09 Sep 2014 11:26:40 -0700 (PDT) Message-ID: <20140909.112640.131028033967197328.davem@davemloft.net> References: <1410286110-24956-1-git-send-email-ricardo.ribalda@gmail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1410286110-24956-1-git-send-email-ricardo.ribalda@gmail.com> Sender: sparclinux-owner@vger.kernel.org To: ricardo.ribalda@gmail.com Cc: sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org List-Id: linux-serial@vger.kernel.org From: Ricardo Ribalda Delgado Date: Tue, 9 Sep 2014 20:08:30 +0200 > diff --git a/arch/sparc/include/uapi/asm/ioctls.h b/arch/sparc/include/uapi/asm/ioctls.h > index 897d172..4e1c5da 100644 > --- a/arch/sparc/include/uapi/asm/ioctls.h > +++ b/arch/sparc/include/uapi/asm/ioctls.h > @@ -24,6 +24,8 @@ > #define TIOCGPKT _IOR('T', 0x38, int) /* Get packet mode state */ > #define TIOCGPTLCK _IOR('T', 0x39, int) /* Get Pty lock state */ > #define TIOCGEXCL _IOR('T', 0x40, int) /* Get exclusive mode state */ > +#define TIOCGRS485 0x542E > +#define TIOCSRS485 0x542F Please follow the ioctl numbering scheme used by the particular architecture UAPI file you are editing. Since Sparc here is using incrementing _IO*() values, including the type for the object passed in/out of the ioctl, you should do similarly for TIOC{G,S}RS485.