From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Bryan O'Donoghue <pure.logic@nexus-software.ie>
Cc: gregkh@linuxfoundation.org, jslaby@suse.cz,
andriy.shevchenko@linux.intel.com, kean.ho.chew@intel.com,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH v3] serial: 8250: Add Quark X1000 to 8250_pci.c
Date: Tue, 23 Sep 2014 10:58:17 +0300 [thread overview]
Message-ID: <20140923075817.GA18814@xps8300> (raw)
In-Reply-To: <1411431671-26540-1-git-send-email-pure.logic@nexus-software.ie>
On Tue, Sep 23, 2014 at 01:21:11AM +0100, Bryan O'Donoghue wrote:
> Quark X1000 contains two designware derived 8250 serial ports.
> Each port has a unique PCI configuration space consisting of
> BAR0:UART BAR1:DMA respectively.
>
> Unlike the standard 8250 the register width is 32 bits for RHR,IER etc
> The Quark UART has a fundamental clock @ 44.2368 MHz allowing for a
> bitrate of up to about 2.76 megabits per second.
>
> This patch enables standard 8250 mode
>
> Signed-off-by: Bryan O'Donoghue <pure.logic@nexus-software.ie>
Looks good to me. FWIW..
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Thanks,
--
heikki
prev parent reply other threads:[~2014-09-23 7:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-23 0:21 [PATCH v3] serial: 8250: Add Quark X1000 to 8250_pci.c Bryan O'Donoghue
2014-09-23 7:58 ` Heikki Krogerus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140923075817.GA18814@xps8300 \
--to=heikki.krogerus@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.cz \
--cc=kean.ho.chew@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=pure.logic@nexus-software.ie \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).