From: Johannes Thumshirn <johannes.thumshirn@men.de>
To: linux-serial@vger.kernel.org
Cc: "Geißler Andreas" <Andreas.Geissler@men.de>,
"Johannes Thumshirn" <Johannes.Thumshirn@men.de>
Subject: Handling of automatic flow control in UART drivers
Date: Mon, 13 Oct 2014 16:48:39 +0200 [thread overview]
Message-ID: <20141013144831.GA8409@jtlinux> (raw)
Hi,
We have problem with automatic flow control (i.e. auto RTS/CTS handshaking) in
our uart driver (men_z135_uart.c). It's probably less a technical but a problem
with me understanding the API.
I active the hardware auto flow control feature on the CRTSCTS flag in my
uart_ops->set_termios() function. But then the RTS flag is set on every call of
the uart_ops->set_mctrl() function, this seems to confuse the hardware. Is there
a way to tell the tty layer that flow control is handled solely by hardware?
I.e. is there a way of telling serial core to leave out the calls to
uart_set_mctrl()/uart_clear_mctrl() in uart_throttle()/uart_unthrottle(), or is
setting UPF_FLOW_HARD and then implementing a dummy port->ops->{un}throttle()
the correct way?
Are there any drivers that use a hardware's automatic flow control feature I can
use as an example? A fast grep on AFE reveals some spots, but I can't really
find a difference to my implementation.
Thanks in advance,
Johannes
next reply other threads:[~2014-10-13 14:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-13 14:48 Johannes Thumshirn [this message]
2014-10-13 17:09 ` Handling of automatic flow control in UART drivers Grant Edwards
2014-10-13 17:13 ` Peter Hurley
2014-10-14 9:22 ` Johannes Thumshirn
2014-10-14 11:18 ` Peter Hurley
2014-10-23 5:51 ` Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141013144831.GA8409@jtlinux \
--to=johannes.thumshirn@men.de \
--cc=Andreas.Geissler@men.de \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).