* [PATCH] serial: atmel: add missing dmaengine header
@ 2014-10-16 7:39 Vinod Koul
2014-10-16 8:42 ` Andy Shevchenko
2014-10-16 9:10 ` Greg Kroah-Hartman
0 siblings, 2 replies; 6+ messages in thread
From: Vinod Koul @ 2014-10-16 7:39 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Nicolas Ferre, Jiri Slaby, linux-serial, dmaengine,
Andy Shevchenko, Vinod Koul
The atmel serial driver uses dmaengine APIs but never included the dmaengine
header as it was getting inculded thru one of driver headers.
commit 3d588f83e4d6a5230d9094b97d38621cbaa9a972 - "dmaengine: dw: split
dma-dw.h to platform and private parts" broke this as it moved headers
around. Fix this by doing the right thing to include the dmaengine header
Reported-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
---
Greg, since this is path which broke this is sitting in my next, would it be
okay to carry this thru dmaengine tree as get it merged in current window.
Planning to send pull request in day or so to Linus
drivers/tty/serial/atmel_serial.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/tty/serial/atmel_serial.c b/drivers/tty/serial/atmel_serial.c
index d7d4584..edde3ec 100644
--- a/drivers/tty/serial/atmel_serial.c
+++ b/drivers/tty/serial/atmel_serial.c
@@ -37,6 +37,7 @@
#include <linux/of_device.h>
#include <linux/of_gpio.h>
#include <linux/dma-mapping.h>
+#include <linux/dmaengine.h>
#include <linux/atmel_pdc.h>
#include <linux/atmel_serial.h>
#include <linux/uaccess.h>
--
1.7.0.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] serial: atmel: add missing dmaengine header
2014-10-16 8:42 ` Andy Shevchenko
@ 2014-10-16 8:11 ` Vinod Koul
0 siblings, 0 replies; 6+ messages in thread
From: Vinod Koul @ 2014-10-16 8:11 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Greg Kroah-Hartman, Nicolas Ferre, Jiri Slaby, linux-serial,
dmaengine
On Thu, Oct 16, 2014 at 11:42:09AM +0300, Andy Shevchenko wrote:
> On Thu, 2014-10-16 at 13:09 +0530, Vinod Koul wrote:
> > The atmel serial driver uses dmaengine APIs but never included the dmaengine
> > header as it was getting inculded thru one of driver headers.
> >
> > commit 3d588f83e4d6a5230d9094b97d38621cbaa9a972 - "dmaengine: dw: split
> > dma-dw.h to platform and private parts" broke this as it moved headers
> > around. Fix this by doing the right thing to include the dmaengine header
> >
>
> Thanks, I just sent similar idea to Fengguang and you.
>
> I don't know if it would be a stable material. If so, it would be nice
> to add:
>
> Fixes: 08f738be88bb (serial: at91: add tx dma support)
> Cc: stable@vger.kernel.org
Fixes yes, but am not too keen on marking this stable as it wont show up
unless we have 3d588f8
--
~Vinod
>
> > Reported-by: kbuild test robot <fengguang.wu@intel.com>
> > Signed-off-by: Vinod Koul <vinod.koul@intel.com>
> > ---
> > Greg, since this is path which broke this is sitting in my next, would it be
> > okay to carry this thru dmaengine tree as get it merged in current window.
> > Planning to send pull request in day or so to Linus
> >
> > drivers/tty/serial/atmel_serial.c | 1 +
> > 1 files changed, 1 insertions(+), 0 deletions(-)
> >
> > diff --git a/drivers/tty/serial/atmel_serial.c b/drivers/tty/serial/atmel_serial.c
> > index d7d4584..edde3ec 100644
> > --- a/drivers/tty/serial/atmel_serial.c
> > +++ b/drivers/tty/serial/atmel_serial.c
> > @@ -37,6 +37,7 @@
> > #include <linux/of_device.h>
> > #include <linux/of_gpio.h>
> > #include <linux/dma-mapping.h>
> > +#include <linux/dmaengine.h>
> > #include <linux/atmel_pdc.h>
> > #include <linux/atmel_serial.h>
> > #include <linux/uaccess.h>
>
>
> --
> Andy Shevchenko <andriy.shevchenko@intel.com>
> Intel Finland Oy
>
--
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] serial: atmel: add missing dmaengine header
2014-10-16 7:39 [PATCH] serial: atmel: add missing dmaengine header Vinod Koul
@ 2014-10-16 8:42 ` Andy Shevchenko
2014-10-16 8:11 ` Vinod Koul
2014-10-16 9:10 ` Greg Kroah-Hartman
1 sibling, 1 reply; 6+ messages in thread
From: Andy Shevchenko @ 2014-10-16 8:42 UTC (permalink / raw)
To: Vinod Koul
Cc: Greg Kroah-Hartman, Nicolas Ferre, Jiri Slaby, linux-serial,
dmaengine
On Thu, 2014-10-16 at 13:09 +0530, Vinod Koul wrote:
> The atmel serial driver uses dmaengine APIs but never included the dmaengine
> header as it was getting inculded thru one of driver headers.
>
> commit 3d588f83e4d6a5230d9094b97d38621cbaa9a972 - "dmaengine: dw: split
> dma-dw.h to platform and private parts" broke this as it moved headers
> around. Fix this by doing the right thing to include the dmaengine header
>
Thanks, I just sent similar idea to Fengguang and you.
I don't know if it would be a stable material. If so, it would be nice
to add:
Fixes: 08f738be88bb (serial: at91: add tx dma support)
Cc: stable@vger.kernel.org
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> Signed-off-by: Vinod Koul <vinod.koul@intel.com>
> ---
> Greg, since this is path which broke this is sitting in my next, would it be
> okay to carry this thru dmaengine tree as get it merged in current window.
> Planning to send pull request in day or so to Linus
>
> drivers/tty/serial/atmel_serial.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/tty/serial/atmel_serial.c b/drivers/tty/serial/atmel_serial.c
> index d7d4584..edde3ec 100644
> --- a/drivers/tty/serial/atmel_serial.c
> +++ b/drivers/tty/serial/atmel_serial.c
> @@ -37,6 +37,7 @@
> #include <linux/of_device.h>
> #include <linux/of_gpio.h>
> #include <linux/dma-mapping.h>
> +#include <linux/dmaengine.h>
> #include <linux/atmel_pdc.h>
> #include <linux/atmel_serial.h>
> #include <linux/uaccess.h>
--
Andy Shevchenko <andriy.shevchenko@intel.com>
Intel Finland Oy
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] serial: atmel: add missing dmaengine header
2014-10-16 9:10 ` Greg Kroah-Hartman
@ 2014-10-16 8:56 ` Vinod Koul
2014-10-16 13:48 ` Nicolas Ferre
0 siblings, 1 reply; 6+ messages in thread
From: Vinod Koul @ 2014-10-16 8:56 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Nicolas Ferre, Jiri Slaby, linux-serial, dmaengine,
Andy Shevchenko
On Thu, Oct 16, 2014 at 11:10:59AM +0200, Greg Kroah-Hartman wrote:
> On Thu, Oct 16, 2014 at 01:09:57PM +0530, Vinod Koul wrote:
> > The atmel serial driver uses dmaengine APIs but never included the dmaengine
> > header as it was getting inculded thru one of driver headers.
> >
> > commit 3d588f83e4d6a5230d9094b97d38621cbaa9a972 - "dmaengine: dw: split
> > dma-dw.h to platform and private parts" broke this as it moved headers
> > around. Fix this by doing the right thing to include the dmaengine header
> >
> > Reported-by: kbuild test robot <fengguang.wu@intel.com>
> > Signed-off-by: Vinod Koul <vinod.koul@intel.com>
> > ---
> > Greg, since this is path which broke this is sitting in my next, would it be
> > okay to carry this thru dmaengine tree as get it merged in current window.
> > Planning to send pull request in day or so to Linus
>
> Sure, that's fine with me:
>
> Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Thanks :)
Applied, and pushed now
--
~Vinod
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] serial: atmel: add missing dmaengine header
2014-10-16 7:39 [PATCH] serial: atmel: add missing dmaengine header Vinod Koul
2014-10-16 8:42 ` Andy Shevchenko
@ 2014-10-16 9:10 ` Greg Kroah-Hartman
2014-10-16 8:56 ` Vinod Koul
1 sibling, 1 reply; 6+ messages in thread
From: Greg Kroah-Hartman @ 2014-10-16 9:10 UTC (permalink / raw)
To: Vinod Koul
Cc: Nicolas Ferre, Jiri Slaby, linux-serial, dmaengine,
Andy Shevchenko
On Thu, Oct 16, 2014 at 01:09:57PM +0530, Vinod Koul wrote:
> The atmel serial driver uses dmaengine APIs but never included the dmaengine
> header as it was getting inculded thru one of driver headers.
>
> commit 3d588f83e4d6a5230d9094b97d38621cbaa9a972 - "dmaengine: dw: split
> dma-dw.h to platform and private parts" broke this as it moved headers
> around. Fix this by doing the right thing to include the dmaengine header
>
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> Signed-off-by: Vinod Koul <vinod.koul@intel.com>
> ---
> Greg, since this is path which broke this is sitting in my next, would it be
> okay to carry this thru dmaengine tree as get it merged in current window.
> Planning to send pull request in day or so to Linus
Sure, that's fine with me:
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] serial: atmel: add missing dmaengine header
2014-10-16 8:56 ` Vinod Koul
@ 2014-10-16 13:48 ` Nicolas Ferre
0 siblings, 0 replies; 6+ messages in thread
From: Nicolas Ferre @ 2014-10-16 13:48 UTC (permalink / raw)
To: Vinod Koul, Greg Kroah-Hartman
Cc: Jiri Slaby, linux-serial, dmaengine, Andy Shevchenko
On 16/10/2014 10:56, Vinod Koul :
> On Thu, Oct 16, 2014 at 11:10:59AM +0200, Greg Kroah-Hartman wrote:
>> On Thu, Oct 16, 2014 at 01:09:57PM +0530, Vinod Koul wrote:
>>> The atmel serial driver uses dmaengine APIs but never included the dmaengine
>>> header as it was getting inculded thru one of driver headers.
>>>
>>> commit 3d588f83e4d6a5230d9094b97d38621cbaa9a972 - "dmaengine: dw: split
>>> dma-dw.h to platform and private parts" broke this as it moved headers
>>> around. Fix this by doing the right thing to include the dmaengine header
>>>
>>> Reported-by: kbuild test robot <fengguang.wu@intel.com>
>>> Signed-off-by: Vinod Koul <vinod.koul@intel.com>
>>> ---
>>> Greg, since this is path which broke this is sitting in my next, would it be
>>> okay to carry this thru dmaengine tree as get it merged in current window.
>>> Planning to send pull request in day or so to Linus
>>
>> Sure, that's fine with me:
>>
>> Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Thanks :)
>
> Applied, and pushed now
Vinod, thanks a lot for having handled this issue.
For the record even if it's too late:
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Bye,
--
Nicolas Ferre
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-10-16 13:48 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-16 7:39 [PATCH] serial: atmel: add missing dmaengine header Vinod Koul
2014-10-16 8:42 ` Andy Shevchenko
2014-10-16 8:11 ` Vinod Koul
2014-10-16 9:10 ` Greg Kroah-Hartman
2014-10-16 8:56 ` Vinod Koul
2014-10-16 13:48 ` Nicolas Ferre
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).