From: "Piotr Król" <piotr.krol@3mdeb.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: linux-serial@vger.kernel.org, jslaby@suse.cz, gregkh@linuxfoundation.org
Subject: Re: amba-pl011 complains about DMA for bcm2835 where it is not supported
Date: Tue, 28 Oct 2014 01:09:23 +0100 [thread overview]
Message-ID: <20141028000922.GB1788@haysend> (raw)
In-Reply-To: <20141027235942.GY27405@n2100.arm.linux.org.uk>
On Mon, Oct 27, 2014 at 11:59:42PM +0000, Russell King - ARM Linux wrote:
> On Tue, Oct 28, 2014 at 12:44:31AM +0100, Piotr Król wrote:
> > Hi all,
> > according to BCM2835 ARM Peripherals spec DMA is optional functionality
> > for ARM PL011 UART and it is not supported on this SoC. It looks like
> > amba-pl011 search for device tree property (dma-names) unconditionally,
> > what leads to error message:
> >
> > of_dma_request_slave_channel: dma-names property of node '/soc/uart@7e201000' missing or empty
> > uart-pl011 20201000.uart: no DMA platform data
> >
> > I assume that if it is possible that amba-pl011 can be without DMA we
> > should check if DMA is supported and then try to read properties. Is
> > there any known method for checking dma support ? If yes that I would be
> > glad for any pointers.
> >
> > Let me know if I should ignore/accept this error message or there is
> > some code fix needed.
>
> A great many implementations of PL011 do not have DMA support (some have
> DMA support but its well broken.) The driver has always supported PIO
> mode, and continues to do so.
>
Driver works fine but IMHO this error message confuse user. Should I assume
that error message is expected and we should not avoid it by trying to
check if DMA is supported ?
BTW above error message do not indicate that DMA is not supported but
indicates that something is wrong with DT, what in this case is not true.
Thanks,
Piotr Król
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-10-28 0:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-27 23:44 amba-pl011 complains about DMA for bcm2835 where it is not supported Piotr Król
2014-10-27 23:59 ` Russell King - ARM Linux
2014-10-28 0:09 ` Piotr Król [this message]
2014-10-28 0:16 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141028000922.GB1788@haysend \
--to=piotr.krol@3mdeb.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.cz \
--cc=linux-serial@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox