From: Lee Jones <lee.jones@linaro.org>
To: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
Cc: Robert Jarzmik <robert.jarzmik@free.fr>,
Daniel Mack <daniel@zonque.org>,
Haojian Zhuang <haojian.zhuang@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Wolfram Sang <wsa@the-dreams.de>,
Samuel Ortiz <sameo@linux.intel.com>, Felipe Balbi <balbi@ti.com>,
Jiri Slaby <jslaby@suse.cz>,
linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-serial@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH V2 4/5] mfd: t7l66xb: prepare/unprepare clocks
Date: Tue, 18 Nov 2014 13:14:34 +0000 [thread overview]
Message-ID: <20141118131434.GA24004@x1> (raw)
In-Reply-To: <1416236863-20898-4-git-send-email-dbaryshkov@gmail.com>
On Mon, 17 Nov 2014, Dmitry Eremin-Solenikov wrote:
> Change clk_enable/disable() calls to clk_prepare_enable() and
> clk_disable_unprepare().
>
> Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
> ---
> drivers/mfd/t7l66xb.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
Applied, thanks.
> diff --git a/drivers/mfd/t7l66xb.c b/drivers/mfd/t7l66xb.c
> index 9e04a74..439d905 100644
> --- a/drivers/mfd/t7l66xb.c
> +++ b/drivers/mfd/t7l66xb.c
> @@ -87,7 +87,7 @@ static int t7l66xb_mmc_enable(struct platform_device *mmc)
> unsigned long flags;
> u8 dev_ctl;
>
> - clk_enable(t7l66xb->clk32k);
> + clk_prepare_enable(t7l66xb->clk32k);
>
> spin_lock_irqsave(&t7l66xb->lock, flags);
>
> @@ -118,7 +118,7 @@ static int t7l66xb_mmc_disable(struct platform_device *mmc)
>
> spin_unlock_irqrestore(&t7l66xb->lock, flags);
>
> - clk_disable(t7l66xb->clk32k);
> + clk_disable_unprepare(t7l66xb->clk32k);
>
> return 0;
> }
> @@ -285,7 +285,7 @@ static int t7l66xb_suspend(struct platform_device *dev, pm_message_t state)
>
> if (pdata && pdata->suspend)
> pdata->suspend(dev);
> - clk_disable(t7l66xb->clk48m);
> + clk_disable_unprepare(t7l66xb->clk48m);
>
> return 0;
> }
> @@ -295,7 +295,7 @@ static int t7l66xb_resume(struct platform_device *dev)
> struct t7l66xb *t7l66xb = platform_get_drvdata(dev);
> struct t7l66xb_platform_data *pdata = dev_get_platdata(&dev->dev);
>
> - clk_enable(t7l66xb->clk48m);
> + clk_prepare_enable(t7l66xb->clk48m);
> if (pdata && pdata->resume)
> pdata->resume(dev);
>
> @@ -369,7 +369,7 @@ static int t7l66xb_probe(struct platform_device *dev)
> goto err_ioremap;
> }
>
> - clk_enable(t7l66xb->clk48m);
> + clk_prepare_enable(t7l66xb->clk48m);
>
> if (pdata && pdata->enable)
> pdata->enable(dev);
> @@ -414,9 +414,9 @@ static int t7l66xb_remove(struct platform_device *dev)
> int ret;
>
> ret = pdata->disable(dev);
> - clk_disable(t7l66xb->clk48m);
> + clk_disable_unprepare(t7l66xb->clk48m);
> clk_put(t7l66xb->clk48m);
> - clk_disable(t7l66xb->clk32k);
> + clk_disable_unprepare(t7l66xb->clk32k);
> clk_put(t7l66xb->clk32k);
> t7l66xb_detach_irq(dev);
> iounmap(t7l66xb->scr);
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2014-11-18 13:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-17 15:07 [PATCH V2 1/5] serial: pxa: prepare/unprepare clocks Dmitry Eremin-Solenikov
2014-11-17 15:07 ` [PATCH V2 2/5] i2c: " Dmitry Eremin-Solenikov
2014-11-17 15:51 ` Russell King - ARM Linux
[not found] ` <1416236863-20898-2-git-send-email-dbaryshkov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-11-17 18:26 ` Wolfram Sang
[not found] ` <1416236863-20898-1-git-send-email-dbaryshkov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-11-17 15:07 ` [PATCH V2 3/5] usb: gadget: pxa25x_udc: prepare/unprepare clocks in pxa-ssp Dmitry Eremin-Solenikov
2014-11-17 18:44 ` Robert Jarzmik
2014-11-17 15:07 ` [PATCH V2 5/5] mfd: tc6387xb: prepare/unprepare clocks Dmitry Eremin-Solenikov
2014-11-18 12:04 ` Lee Jones
2014-11-17 15:51 ` [PATCH V2 1/5] serial: pxa: " Russell King - ARM Linux
2014-11-17 15:07 ` [PATCH V2 4/5] mfd: t7l66xb: " Dmitry Eremin-Solenikov
2014-11-18 13:14 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141118131434.GA24004@x1 \
--to=lee.jones@linaro.org \
--cc=balbi@ti.com \
--cc=daniel@zonque.org \
--cc=dbaryshkov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=haojian.zhuang@gmail.com \
--cc=jslaby@suse.cz \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=robert.jarzmik@free.fr \
--cc=sameo@linux.intel.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).