From: Tony Lindgren <tony@atomide.com>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>,
linux-serial@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Sekhar Nori <nsekhar@ti.com>, Felipe Balbi <balbi@ti.com>,
uwe@kleine-koenig.org
Subject: Re: [PATCH] tty: serial: serial-omap: depend on !8250_omap
Date: Mon, 1 Dec 2014 09:39:33 -0800 [thread overview]
Message-ID: <20141201173932.GB2817@atomide.com> (raw)
In-Reply-To: <547CA483.3070801@linutronix.de>
* Sebastian Andrzej Siewior <bigeasy@linutronix.de> [141201 09:27]:
> On 12/01/2014 05:38 PM, Tony Lindgren wrote:
> > * One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk> [141201 06:11]:
> >>> Well the nightmare userspace switch from ttyS to ttyO few years ago is
> >>> something we want to avoid.. I think the best solution would be to make
> >>> serial-omap.c transparently provide support for ttyO using the new 8250
> >>> code so both ttyS and ttyO devices would just work. Otherwise it will
> >>> be years of "my serial port stopped working" questions again.
> >>
> >> Thata a udev problem not a kernel one surely.
> >
> > How do you suggest we get people to update their kernel command line
> > and inittab? Udev may not even be installed.
>
> There are three use cases that I can think of right now:
> - people that enable that new driver via oldconfig
> I would expect that they read the help message in Kconfig. No worry
> about them.
>
> - people that get a complete system via magic_build_tool (may yocto or
> whatever)
> If $TOOL decides to use the new driver, then it should update
> commandline in bootloader. Those things create usually bootloader +
> kernel + rootfile system. If the commandline is saved on flash/mmc
> then it won't be reset from default. However udev should help here.
> So not a problem either (udev can't fix the kernel boot output but we
> should see atleast the login console).
>
> - people that build omap2plus_defconfig and we switch to the new driver
> Those people get switched from one driver to the other without
> knowing. This is what I tried to bring to everyone's attention. The
> defconfig hasn't been changed yet so it is not problem for next
> release (yet).
>
> I agree that this is a user problem. We agreed not to introduce a
> console proxy in kernel _or_ hack the command line in kernel (to
> replace O with S).
> So I think the problem boils down to educate the user about this
> change. Making the old driver disappear was one way of getting the
> user's attention. Another idea would be to introduce a #warning which is
> also activated by the defconfig and informs the user about the change.
> Ideally this #warning could be switched off by Kconfig once the user
> reads & deactivates it. This requires the pay attention to warnings
> during build. #error would make sure he does but it breaks auto-builds
> so it is not an option.
The problem is the kernel will just mysteriously stop outputting
anything if we enable the new driver. This is a "flag day" type
problem that needs the user to somehow coordinate the kernel version,
kernel .config, kernel cmdline, dev entries, and the inittab.
Regards,
Tony
next prev parent reply other threads:[~2014-12-01 17:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-26 22:01 [PATCH] tty: serial: serial-omap: depend on !8250_omap Sebastian Andrzej Siewior
2014-11-29 9:48 ` Sebastian Andrzej Siewior
2014-11-29 17:34 ` Tony Lindgren
2014-12-01 14:09 ` One Thousand Gnomes
2014-12-01 16:38 ` Tony Lindgren
2014-12-01 17:25 ` Sebastian Andrzej Siewior
2014-12-01 17:39 ` Tony Lindgren [this message]
2014-12-01 23:13 ` Aaro Koskinen
2014-12-02 1:51 ` Felipe Balbi
2014-12-05 13:51 ` One Thousand Gnomes
2014-12-18 17:47 ` [PATCH] tty: serial: 8250: omap: add ttySx console if the user didn't Sebastian Andrzej Siewior
2015-01-05 21:26 ` One Thousand Gnomes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141201173932.GB2817@atomide.com \
--to=tony@atomide.com \
--cc=balbi@ti.com \
--cc=bigeasy@linutronix.de \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=uwe@kleine-koenig.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).