[PATCH/RFC] serial: sh-sci: Remove overrun message

[PATCH/RFC] serial: sh-sci: Remove overrun message

[Yoshihiro Kaneko]

From: Hisashi Nakamura <hisashi.nakamura.ak@renesas.com>

Since the driver cannot return from overrun error if characters
are output during overrun process, the error message of overrun
is removed.

Signed-off-by: Hisashi Nakamura <hisashi.nakamura.ak@renesas.com>
Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
---

This patch is based on the tty-next branch of Greg Kroah-Hartman's tty
tree.

 drivers/tty/serial/sh-sci.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/tty/serial/sh-sci.c b/drivers/tty/serial/sh-sci.c
index fccebbd..fe2bb08 100644
--- a/drivers/tty/serial/sh-sci.c
+++ b/drivers/tty/serial/sh-sci.c
@@ -858,7 +858,6 @@ static int sci_handle_fifo_overrun(struct uart_port *port)
 		tty_insert_flip_char(tport, 0, TTY_OVERRUN);
 		tty_flip_buffer_push(tport);
 
-		dev_notice(port->dev, "overrun error\n");
 		copied++;
 	}
 
-- 
1.9.1

Re: [PATCH/RFC] serial: sh-sci: Remove overrun message

[Greg Kroah-Hartman]

On Mon, Dec 15, 2014 at 11:13:13PM +0900, Yoshihiro Kaneko wrote:
> From: Hisashi Nakamura <hisashi.nakamura.ak@renesas.com>
> 
> Since the driver cannot return from overrun error if characters
> are output during overrun process, the error message of overrun
> is removed.
> 
> Signed-off-by: Hisashi Nakamura <hisashi.nakamura.ak@renesas.com>
> Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
> ---
> 
> This patch is based on the tty-next branch of Greg Kroah-Hartman's tty
> tree.
> 
>  drivers/tty/serial/sh-sci.c | 1 -
>  1 file changed, 1 deletion(-)

I don't apply "RFC" patches, as it is evident that you don't feel they
should be applied.

Please resend anything without that marking if you want me to apply
them.

thanks,

greg k-h

Re: [PATCH/RFC] serial: sh-sci: Remove overrun message

[Geert Uytterhoeven]

On Mon, Dec 15, 2014 at 3:13 PM, Yoshihiro Kaneko <ykaneko0929@gmail.com> wrote:
> From: Hisashi Nakamura <hisashi.nakamura.ak@renesas.com>
>
> Since the driver cannot return from overrun error if characters
> are output during overrun process, the error message of overrun
> is removed.
>
> Signed-off-by: Hisashi Nakamura <hisashi.nakamura.ak@renesas.com>
> Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
> ---
>
> This patch is based on the tty-next branch of Greg Kroah-Hartman's tty
> tree.
>
>  drivers/tty/serial/sh-sci.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/tty/serial/sh-sci.c b/drivers/tty/serial/sh-sci.c
> index fccebbd..fe2bb08 100644
> --- a/drivers/tty/serial/sh-sci.c
> +++ b/drivers/tty/serial/sh-sci.c
> @@ -858,7 +858,6 @@ static int sci_handle_fifo_overrun(struct uart_port *port)
>                 tty_insert_flip_char(tport, 0, TTY_OVERRUN);
>                 tty_flip_buffer_push(tport);
>
> -               dev_notice(port->dev, "overrun error\n");
>                 copied++;
>         }

What about replacing it by a call to dev_dbg() instead?
That way it won't be printed during normal use, but depending on the
system's setting it can still be logged in syslog.

Or do you think it's sufficient to have it in the statistics only?

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH/RFC] serial: sh-sci: Remove overrun message

[Simon Horman]

On Tue, Jan 13, 2015 at 08:57:48AM +0100, Geert Uytterhoeven wrote:
> On Mon, Dec 15, 2014 at 3:13 PM, Yoshihiro Kaneko <ykaneko0929@gmail.com> wrote:
> > From: Hisashi Nakamura <hisashi.nakamura.ak@renesas.com>
> >
> > Since the driver cannot return from overrun error if characters
> > are output during overrun process, the error message of overrun
> > is removed.
> >
> > Signed-off-by: Hisashi Nakamura <hisashi.nakamura.ak@renesas.com>
> > Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
> > ---
> >
> > This patch is based on the tty-next branch of Greg Kroah-Hartman's tty
> > tree.
> >
> >  drivers/tty/serial/sh-sci.c | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/tty/serial/sh-sci.c b/drivers/tty/serial/sh-sci.c
> > index fccebbd..fe2bb08 100644
> > --- a/drivers/tty/serial/sh-sci.c
> > +++ b/drivers/tty/serial/sh-sci.c
> > @@ -858,7 +858,6 @@ static int sci_handle_fifo_overrun(struct uart_port *port)
> >                 tty_insert_flip_char(tport, 0, TTY_OVERRUN);
> >                 tty_flip_buffer_push(tport);
> >
> > -               dev_notice(port->dev, "overrun error\n");
> >                 copied++;
> >         }
> 
> What about replacing it by a call to dev_dbg() instead?
> That way it won't be printed during normal use, but depending on the
> system's setting it can still be logged in syslog.
> 
> Or do you think it's sufficient to have it in the statistics only?

I like the dev_dbg() idea.

Kaneko-san, could you see about respinning this patch accordingly?

Re: [PATCH/RFC] serial: sh-sci: Remove overrun message

[Yoshihiro Kaneko]

2015-01-20 15:35 GMT+09:00 Simon Horman <horms@verge.net.au>:
> On Tue, Jan 13, 2015 at 08:57:48AM +0100, Geert Uytterhoeven wrote:
>> On Mon, Dec 15, 2014 at 3:13 PM, Yoshihiro Kaneko <ykaneko0929@gmail.com> wrote:
>> > From: Hisashi Nakamura <hisashi.nakamura.ak@renesas.com>
>> >
>> > Since the driver cannot return from overrun error if characters
>> > are output during overrun process, the error message of overrun
>> > is removed.
>> >
>> > Signed-off-by: Hisashi Nakamura <hisashi.nakamura.ak@renesas.com>
>> > Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
>> > ---
>> >
>> > This patch is based on the tty-next branch of Greg Kroah-Hartman's tty
>> > tree.
>> >
>> >  drivers/tty/serial/sh-sci.c | 1 -
>> >  1 file changed, 1 deletion(-)
>> >
>> > diff --git a/drivers/tty/serial/sh-sci.c b/drivers/tty/serial/sh-sci.c
>> > index fccebbd..fe2bb08 100644
>> > --- a/drivers/tty/serial/sh-sci.c
>> > +++ b/drivers/tty/serial/sh-sci.c
>> > @@ -858,7 +858,6 @@ static int sci_handle_fifo_overrun(struct uart_port *port)
>> >                 tty_insert_flip_char(tport, 0, TTY_OVERRUN);
>> >                 tty_flip_buffer_push(tport);
>> >
>> > -               dev_notice(port->dev, "overrun error\n");
>> >                 copied++;
>> >         }
>>
>> What about replacing it by a call to dev_dbg() instead?
>> That way it won't be printed during normal use, but depending on the
>> system's setting it can still be logged in syslog.
>>
>> Or do you think it's sufficient to have it in the statistics only?
>
> I like the dev_dbg() idea.
>
> Kaneko-san, could you see about respinning this patch accordingly?

Sure, will do!

Thanks,
Kaneko