From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Horman Subject: Re: [PATCH/RFC] serial: sh-sci: Remove overrun message Date: Tue, 20 Jan 2015 15:35:16 +0900 Message-ID: <20150120063516.GB22980@verge.net.au> References: <1418652793-6770-1-git-send-email-ykaneko0929@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-sh-owner@vger.kernel.org To: Geert Uytterhoeven Cc: Yoshihiro Kaneko , "linux-serial@vger.kernel.org" , Greg Kroah-Hartman , Magnus Damm , Linux-sh list List-Id: linux-serial@vger.kernel.org On Tue, Jan 13, 2015 at 08:57:48AM +0100, Geert Uytterhoeven wrote: > On Mon, Dec 15, 2014 at 3:13 PM, Yoshihiro Kaneko wrote: > > From: Hisashi Nakamura > > > > Since the driver cannot return from overrun error if characters > > are output during overrun process, the error message of overrun > > is removed. > > > > Signed-off-by: Hisashi Nakamura > > Signed-off-by: Yoshihiro Kaneko > > --- > > > > This patch is based on the tty-next branch of Greg Kroah-Hartman's tty > > tree. > > > > drivers/tty/serial/sh-sci.c | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/drivers/tty/serial/sh-sci.c b/drivers/tty/serial/sh-sci.c > > index fccebbd..fe2bb08 100644 > > --- a/drivers/tty/serial/sh-sci.c > > +++ b/drivers/tty/serial/sh-sci.c > > @@ -858,7 +858,6 @@ static int sci_handle_fifo_overrun(struct uart_port *port) > > tty_insert_flip_char(tport, 0, TTY_OVERRUN); > > tty_flip_buffer_push(tport); > > > > - dev_notice(port->dev, "overrun error\n"); > > copied++; > > } > > What about replacing it by a call to dev_dbg() instead? > That way it won't be printed during normal use, but depending on the > system's setting it can still be logged in syslog. > > Or do you think it's sufficient to have it in the statistics only? I like the dev_dbg() idea. Kaneko-san, could you see about respinning this patch accordingly?