From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Zubair Lutfullah Kakakhel <Zubair.Kakakhel@imgtec.com>
Cc: Paul Burton <paul.burton@imgtec.com>,
linux-mips@linux-mips.org, Lars-Peter Clausen <lars@metafoo.de>,
linux-serial@vger.kernel.org
Subject: Re: [PATCH 26/36] serial: 8250_jz47xx: support for Ingenic jz47xx UARTs
Date: Mon, 2 Feb 2015 08:32:32 -0800 [thread overview]
Message-ID: <20150202163232.GA7055@kroah.com> (raw)
In-Reply-To: <54CFA5BC.2070103@imgtec.com>
On Mon, Feb 02, 2015 at 04:28:44PM +0000, Zubair Lutfullah Kakakhel wrote:
> Hi Greg,
>
> On 30/01/15 23:31, Greg Kroah-Hartman wrote:
> > On Sun, Jan 18, 2015 at 02:41:21PM -0800, Paul Burton wrote:
> >> Introduce a driver suitable for use with the UARTs present in
> >> Ingenic jz47xx series SoCs. These are described as being ns16550
> >> compatible but aren't quite - they require the setting of an extra bit
> >> in the FCR register to enable the UART module. The serial_out
> >> implementation is the same as that in arch/mips/jz4740/serial.c - which
> >> will shortly be removed.
> >>
> >> Signed-off-by: Paul Burton <paul.burton@imgtec.com>
> >> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> >> Cc: Lars-Peter Clausen <lars@metafoo.de>
> >> Cc: linux-serial@vger.kernel.org
> >> ---
> >> drivers/tty/serial/8250/8250_jz47xx.c | 228 ++++++++++++++++++++++++++++++++++
> >> drivers/tty/serial/8250/Kconfig | 8 ++
> >> drivers/tty/serial/8250/Makefile | 1 +
> >> 3 files changed, 237 insertions(+)
> >> create mode 100644 drivers/tty/serial/8250/8250_jz47xx.c
> >
> > This patch blows up on x86 systems, breaking the build :(
>
> Ouch.
>
> Did you compile after all the patches applied? Or after every single patch.
After every individual patch, like is required :)
> I can't manage to reproduce the build error with all of them applied.
Try it with just this one patch applied.
thanks,
greg k-h
prev parent reply other threads:[~2015-02-02 16:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1421620067-23933-1-git-send-email-paul.burton@imgtec.com>
2015-01-18 22:41 ` [PATCH 26/36] serial: 8250_jz47xx: support for Ingenic jz47xx UARTs Paul Burton
2015-01-30 23:31 ` Greg Kroah-Hartman
2015-02-02 16:28 ` Zubair Lutfullah Kakakhel
2015-02-02 16:32 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150202163232.GA7055@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Zubair.Kakakhel@imgtec.com \
--cc=lars@metafoo.de \
--cc=linux-mips@linux-mips.org \
--cc=linux-serial@vger.kernel.org \
--cc=paul.burton@imgtec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox