linux-serial.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Fabio Estevam <festevam@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	Sascha Hauer <kernel@pengutronix.de>,
	"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>
Subject: Re: [PATCH 4/7] serial: imx: drop support for IRDA
Date: Wed, 18 Feb 2015 23:06:11 +0100	[thread overview]
Message-ID: <20150218220611.GN19388@pengutronix.de> (raw)
In-Reply-To: <CAOMZO5AfE_tikox7d49=9ZtSD8R0_mGuuOQWZEg+E3rTqL4LSA@mail.gmail.com>

Hey Fabio,

On Wed, Feb 18, 2015 at 07:16:39PM -0200, Fabio Estevam wrote:
> On Wed, Feb 18, 2015 at 6:41 PM, Uwe Kleine-König
> <u.kleine-koenig@pengutronix.de> wrote:
> > Support for IRDA was added in 2009 in commit v2.6.31-rc1~399^2~2. There
> > are no in-tree users.
> 
> 'fsl,irda-mode' is still documented at
> Documentation/devicetree/bindings/serial/fsl-imx-uart.txt .
I wondered if I should remove it but decided to not do that for
compatibility reasons. The driver not supporting it any more is a
different thing.

> Is the irda support broken?
It is (was) inconsitent and did some things in strange ways. For example
instead of disabling RC it only disabled the corresponding irqs and
flushed the fifo before reenabling. I couldn't test it because I don't
have such hardware though.

> Maybe there are people using it in out-of-tree dts files?
I expect them to cry at some point if they exist. In this case I'm
willing to help them to reinstanciate support for it.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

  reply	other threads:[~2015-02-18 22:06 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-18 20:41 [PATCH 1/7] serial: imx: drop members from driver data that are only used during probe Uwe Kleine-König
2015-02-18 20:41 ` [PATCH 2/7] serial: imx: reformat and cleanup copyright header Uwe Kleine-König
2015-02-18 20:41 ` [PATCH 3/7] serial: imx: fix comment about which machines use the i.MX21 type Uwe Kleine-König
2015-02-18 20:41 ` [PATCH 4/7] serial: imx: drop support for IRDA Uwe Kleine-König
2015-02-18 21:16   ` Fabio Estevam
2015-02-18 22:06     ` Uwe Kleine-König [this message]
2015-02-18 20:41 ` [PATCH 5/7] serial: imx: Fix handling of receiver overrun Uwe Kleine-König
2015-02-18 20:41 ` [PATCH 6/7] serial: imx: remove long dead code Uwe Kleine-König
2015-02-18 20:41 ` [PATCH 7/7] serial: imx: add support for half duplex rs485 Uwe Kleine-König
2015-02-18 22:09   ` [PATCH 7'/7] fixup! " Uwe Kleine-König
2015-02-19  9:15   ` [PATCH 7/7] " aurélien bouin
2015-02-19  9:37     ` Uwe Kleine-König
2015-02-19  9:45       ` aurélien bouin
2015-02-20 15:34         ` Uwe Kleine-König
2015-02-20 15:53           ` gianluca
2015-02-21  8:58 ` [PATCH 1/7] serial: imx: drop members from driver data that are only used during probe Uwe Kleine-König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150218220611.GN19388@pengutronix.de \
    --to=u.kleine-koenig@pengutronix.de \
    --cc=festevam@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-serial@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).