From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: "aurélien bouin" <a.bouin@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
kernel <kernel@pengutronix.de>,
linux-serial@vger.kernel.org
Subject: Re: [PATCH 7/7] serial: imx: add support for half duplex rs485
Date: Fri, 20 Feb 2015 16:34:11 +0100 [thread overview]
Message-ID: <20150220153411.GP19388@pengutronix.de> (raw)
In-Reply-To: <CAFeThoC2+SGc1ZgQhbBx-pxxzpRJ-61n_fs8BZo8ChFcti3Vqw@mail.gmail.com>
On Thu, Feb 19, 2015 at 10:45:47AM +0100, aurélien bouin wrote:
> I hope this link will be ok :
> http://marc.info/?l=linux-kernel&m=142366865609389&q=raw
Good heavens, this patch is broken. It depends on user space to get the
reference counting for the gpio right if at all. It uses a reserved part
of the struct serial_rs485 while being driver specific. It ignores
gpio_request returning an error (well, it does a dev_err in this case,
but continues to use the gpio). It does change how frame error are
handled even if rs485 is off without mentioning in the changelog.
Are you aware what happens if a user issues the rs485 callback without
being aware that padding[0] has this meaning?
I'm sorry, I like my patch better.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2015-02-20 15:34 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-18 20:41 [PATCH 1/7] serial: imx: drop members from driver data that are only used during probe Uwe Kleine-König
2015-02-18 20:41 ` [PATCH 2/7] serial: imx: reformat and cleanup copyright header Uwe Kleine-König
2015-02-18 20:41 ` [PATCH 3/7] serial: imx: fix comment about which machines use the i.MX21 type Uwe Kleine-König
2015-02-18 20:41 ` [PATCH 4/7] serial: imx: drop support for IRDA Uwe Kleine-König
2015-02-18 21:16 ` Fabio Estevam
2015-02-18 22:06 ` Uwe Kleine-König
2015-02-18 20:41 ` [PATCH 5/7] serial: imx: Fix handling of receiver overrun Uwe Kleine-König
2015-02-18 20:41 ` [PATCH 6/7] serial: imx: remove long dead code Uwe Kleine-König
2015-02-18 20:41 ` [PATCH 7/7] serial: imx: add support for half duplex rs485 Uwe Kleine-König
2015-02-18 22:09 ` [PATCH 7'/7] fixup! " Uwe Kleine-König
2015-02-19 9:15 ` [PATCH 7/7] " aurélien bouin
2015-02-19 9:37 ` Uwe Kleine-König
2015-02-19 9:45 ` aurélien bouin
2015-02-20 15:34 ` Uwe Kleine-König [this message]
2015-02-20 15:53 ` gianluca
2015-02-21 8:58 ` [PATCH 1/7] serial: imx: drop members from driver data that are only used during probe Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150220153411.GP19388@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=a.bouin@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).