From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russell King - ARM Linux Subject: Re: [PATCH REPOST 2/2] serial/amba-pl011: Leave the TX IRQ alone when the UART is not open Date: Thu, 12 Mar 2015 11:04:41 +0000 Message-ID: <20150312110441.GM8656@n2100.arm.linux.org.uk> References: <1425472054-7543-1-git-send-email-Dave.Martin@arm.com> <1425472054-7543-3-git-send-email-Dave.Martin@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1425472054-7543-3-git-send-email-Dave.Martin@arm.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Dave Martin Cc: Greg Kroah-Hartman , Andrew Jackson , Graeme Gregory , linux-serial@vger.kernel.org, Andre Przywara , Jorge Ramirez-Ortiz , linux-arm-kernel@lists.infradead.org List-Id: linux-serial@vger.kernel.org On Wed, Mar 04, 2015 at 12:27:34PM +0000, Dave Martin wrote: > Getting the TX IRQ re-asserted from scratch can be inefficient in > some setups. > > This patch avoids clearing the TX IRQ across pl011_shutdown()... > pl011_startup(), so that if the port is closed and reopened, the > IRQ will still work afterwards without having to bootstrap it again. So if a port is being used as the console, we end up spraying the system with transmit interrupts? This can't be right. -- FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up according to speedtest.net.