From: Dave Martin <Dave.Martin@arm.com>
To: Jakub Kicinski <moorray3@wp.pl>
Cc: Russell King <linux@arm.linux.org.uk>,
Jakub Kicinski <kubakici@wp.pl>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Andrew Jackson <Andrew.Jackson@arm.com>,
Graeme Gregory <gg@slimlogic.co.uk>,
linux-serial@vger.kernel.org,
Andre Przywara <Andre.Przywara@arm.com>,
popcorn mix <popcornmix@gmail.com>,
Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 2/2] serial/amba-pl011: Refactor and simplify TX FIFO handling
Date: Mon, 30 Mar 2015 17:07:44 +0100 [thread overview]
Message-ID: <20150330160743.GD22949@e103592.cambridge.arm.com> (raw)
In-Reply-To: <20150330162652.0f0c7a18@north>
On Mon, Mar 30, 2015 at 04:26:52PM +0200, Jakub Kicinski wrote:
> On Mon, 30 Mar 2015 13:28:40 +0100, Dave Martin wrote:
[...]
> > TXIS reflects the live status of the FIFO, except that it is
> > "spuriously" deasserted betweem reset/clear of the interrupt and the
> > first TX IRQ, even though the FIFO may be empty.
>
> I missed that IRQ is cleared by writing data.
No worries, it took me a fair while to be sure of that myself. The TRM
is not very clear on it.
Thanks for the careful review.
Cheers
---Dave
next prev parent reply other threads:[~2015-03-30 16:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-27 14:59 [PATCH v4 0/2] serial/amba-pl011: Activate TX IRQ passively (rework) Dave Martin
2015-03-27 14:59 ` [PATCH v4 1/2] Revert "serial/amba-pl011: Leave the TX IRQ alone when the UART is not open" Dave Martin
2015-03-27 14:59 ` [PATCH v4 2/2] serial/amba-pl011: Refactor and simplify TX FIFO handling Dave Martin
2015-03-27 16:40 ` Jakub Kiciński
2015-03-27 17:42 ` Dave P Martin
2015-03-27 18:10 ` Jakub Kiciński
2015-03-30 12:28 ` Dave Martin
2015-03-30 14:26 ` Jakub Kiciński
2015-03-30 16:07 ` Dave Martin [this message]
2015-03-30 14:28 ` Jakub Kiciński
2015-03-30 16:09 ` Dave Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150330160743.GD22949@e103592.cambridge.arm.com \
--to=dave.martin@arm.com \
--cc=Andre.Przywara@arm.com \
--cc=Andrew.Jackson@arm.com \
--cc=gg@slimlogic.co.uk \
--cc=gregkh@linuxfoundation.org \
--cc=jorge.ramirez-ortiz@linaro.org \
--cc=kubakici@wp.pl \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=moorray3@wp.pl \
--cc=popcornmix@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox