From: Valentin Rothberg <valentinrothberg@gmail.com>
To: Peter Hurley <peter@hurleysoftware.com>
Cc: gregkh@linuxfoundation.org, jslaby@suse.cz,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/tty/serial/mcf.c: fix typo on MCF_CONSOLE
Date: Sun, 12 Apr 2015 18:00:54 +0200 [thread overview]
Message-ID: <20150412160054.GA3152@station> (raw)
In-Reply-To: <552A949B.5010006@hurleysoftware.com>
Hi Peter,
On Sun, Apr 12, 2015 at 11:51:55AM -0400, Peter Hurley wrote:
> Hi Valentin,
>
> On 04/12/2015 11:10 AM, Valentin Rothberg wrote:
> > Correct reference in C-comment after #endif.
> >
> > Signed-off-by: Valentin Rothberg <valentinrothberg@gmail.com>
> > ---
> > I found this issue with ./scripts/checkkconfigsymbols.py
> > ---
> > drivers/tty/serial/mcf.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/tty/serial/mcf.c b/drivers/tty/serial/mcf.c
> > index a9b0ab38a68c..a61031eca1b7 100644
> > --- a/drivers/tty/serial/mcf.c
> > +++ b/drivers/tty/serial/mcf.c
> > @@ -597,7 +597,7 @@ console_initcall(mcf_console_init);
> > #define MCF_CONSOLE NULL
> >
> > /****************************************************************************/
> > -#endif /* CONFIG_MCF_CONSOLE */
> > +#endif /* MCF_CONSOLE */
>
> Please check your results; the correct change would be
>
> #endif /* CONFIG_SERIAL_MCF_CONSOLE */
Thank you for catching that. That's what I intended to; sorry for
this mistake. I'll send a second corrected version of this patch.
Kind regards,
Valentin
> Regards,
> Peter Hurley
>
> > /****************************************************************************/
> >
> > /*
> >
>
prev parent reply other threads:[~2015-04-12 16:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-12 15:10 [PATCH] drivers/tty/serial/mcf.c: fix typo on MCF_CONSOLE Valentin Rothberg
2015-04-12 15:51 ` Peter Hurley
2015-04-12 16:00 ` Valentin Rothberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150412160054.GA3152@station \
--to=valentinrothberg@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=peter@hurleysoftware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).