* [PATCH] drivers/tty/serial/mcf.c: fix typo on MCF_CONSOLE
@ 2015-04-12 15:10 Valentin Rothberg
2015-04-12 15:51 ` Peter Hurley
0 siblings, 1 reply; 3+ messages in thread
From: Valentin Rothberg @ 2015-04-12 15:10 UTC (permalink / raw)
To: gregkh, jslaby, linux-serial, linux-kernel; +Cc: Valentin Rothberg
Correct reference in C-comment after #endif.
Signed-off-by: Valentin Rothberg <valentinrothberg@gmail.com>
---
I found this issue with ./scripts/checkkconfigsymbols.py
---
drivers/tty/serial/mcf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/serial/mcf.c b/drivers/tty/serial/mcf.c
index a9b0ab38a68c..a61031eca1b7 100644
--- a/drivers/tty/serial/mcf.c
+++ b/drivers/tty/serial/mcf.c
@@ -597,7 +597,7 @@ console_initcall(mcf_console_init);
#define MCF_CONSOLE NULL
/****************************************************************************/
-#endif /* CONFIG_MCF_CONSOLE */
+#endif /* MCF_CONSOLE */
/****************************************************************************/
/*
--
2.1.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drivers/tty/serial/mcf.c: fix typo on MCF_CONSOLE
2015-04-12 15:10 [PATCH] drivers/tty/serial/mcf.c: fix typo on MCF_CONSOLE Valentin Rothberg
@ 2015-04-12 15:51 ` Peter Hurley
2015-04-12 16:00 ` Valentin Rothberg
0 siblings, 1 reply; 3+ messages in thread
From: Peter Hurley @ 2015-04-12 15:51 UTC (permalink / raw)
To: Valentin Rothberg, gregkh, jslaby; +Cc: linux-serial, linux-kernel
Hi Valentin,
On 04/12/2015 11:10 AM, Valentin Rothberg wrote:
> Correct reference in C-comment after #endif.
>
> Signed-off-by: Valentin Rothberg <valentinrothberg@gmail.com>
> ---
> I found this issue with ./scripts/checkkconfigsymbols.py
> ---
> drivers/tty/serial/mcf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/mcf.c b/drivers/tty/serial/mcf.c
> index a9b0ab38a68c..a61031eca1b7 100644
> --- a/drivers/tty/serial/mcf.c
> +++ b/drivers/tty/serial/mcf.c
> @@ -597,7 +597,7 @@ console_initcall(mcf_console_init);
> #define MCF_CONSOLE NULL
>
> /****************************************************************************/
> -#endif /* CONFIG_MCF_CONSOLE */
> +#endif /* MCF_CONSOLE */
Please check your results; the correct change would be
#endif /* CONFIG_SERIAL_MCF_CONSOLE */
Regards,
Peter Hurley
> /****************************************************************************/
>
> /*
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drivers/tty/serial/mcf.c: fix typo on MCF_CONSOLE
2015-04-12 15:51 ` Peter Hurley
@ 2015-04-12 16:00 ` Valentin Rothberg
0 siblings, 0 replies; 3+ messages in thread
From: Valentin Rothberg @ 2015-04-12 16:00 UTC (permalink / raw)
To: Peter Hurley; +Cc: gregkh, jslaby, linux-serial, linux-kernel
Hi Peter,
On Sun, Apr 12, 2015 at 11:51:55AM -0400, Peter Hurley wrote:
> Hi Valentin,
>
> On 04/12/2015 11:10 AM, Valentin Rothberg wrote:
> > Correct reference in C-comment after #endif.
> >
> > Signed-off-by: Valentin Rothberg <valentinrothberg@gmail.com>
> > ---
> > I found this issue with ./scripts/checkkconfigsymbols.py
> > ---
> > drivers/tty/serial/mcf.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/tty/serial/mcf.c b/drivers/tty/serial/mcf.c
> > index a9b0ab38a68c..a61031eca1b7 100644
> > --- a/drivers/tty/serial/mcf.c
> > +++ b/drivers/tty/serial/mcf.c
> > @@ -597,7 +597,7 @@ console_initcall(mcf_console_init);
> > #define MCF_CONSOLE NULL
> >
> > /****************************************************************************/
> > -#endif /* CONFIG_MCF_CONSOLE */
> > +#endif /* MCF_CONSOLE */
>
> Please check your results; the correct change would be
>
> #endif /* CONFIG_SERIAL_MCF_CONSOLE */
Thank you for catching that. That's what I intended to; sorry for
this mistake. I'll send a second corrected version of this patch.
Kind regards,
Valentin
> Regards,
> Peter Hurley
>
> > /****************************************************************************/
> >
> > /*
> >
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-04-12 16:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-04-12 15:10 [PATCH] drivers/tty/serial/mcf.c: fix typo on MCF_CONSOLE Valentin Rothberg
2015-04-12 15:51 ` Peter Hurley
2015-04-12 16:00 ` Valentin Rothberg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).