From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [PATCH] serial: imx: protect Soft Reset of port with lock Date: Mon, 13 Apr 2015 09:20:24 +0200 Message-ID: <20150413072024.GA4473@kroah.com> References: <1426228691-20529-1-git-send-email-jiada_wang@mentor.com> <20150326220113.GA24630@kroah.com> <552B6791.60905@mentor.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <552B6791.60905@mentor.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: jiwang Cc: jslaby@suse.cz, linux-arm-kernel@lists.infradead.org, linux-serial@vger.kernel.org List-Id: linux-serial@vger.kernel.org On Mon, Apr 13, 2015 at 03:52:01PM +0900, jiwang wrote: > Hi Greg > > On 03/27/2015 07:01 AM, Greg KH wrote: > >On Fri, Mar 13, 2015 at 03:38:11PM +0900, Jiada Wang wrote: > >>Previously Soft Reset (clear of SRST bit in UCR2 register) > >>of UART in startup is not protected by lock, which may have race > >>with console_write, as console_write may occur at anytime even > >>when UART port is shutdown. > >> > >>To avoid this race, protect Soft reset of UART port with spin_lock. > >> > >>Signed-off-by: Jiada Wang > >>--- > >> drivers/tty/serial/imx.c | 12 ++++++------ > >> 1 file changed, 6 insertions(+), 6 deletions(-) > >Doesn't apply to my tree :( > Can you tell me which tree are you using? > so that I can submit another patch based same tree. Always either work off of linux-next, or my tty tree, and the tty-next branch of it on git.kernel.org. What tree were you working against, Linus's? If so, please read Documentation/development_process to get an understanding of how the kernel development process works. thanks, greg k-h