From: Bin Gao <bin.gao@linux.intel.com>
To: Paul Bolle <pebolle@tiscali.nl>
Cc: One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
Peter Hurley <peter@hurleysoftware.com>,
Jiri Slaby <jslaby@suse.cz>
Subject: Re: [PATCH v3 1/2] serial_core: add pci uart early console support
Date: Wed, 20 May 2015 10:59:23 -0700 [thread overview]
Message-ID: <20150520175922.GA163133@worksta> (raw)
In-Reply-To: <1432113385.21715.76.camel@x220>
On Wed, May 20, 2015 at 11:16:25AM +0200, Paul Bolle wrote:
> What I should have asked is: do you expect architectures other than X86
> to set HAVE_EARLY_PCI? Because then you should put that Kconfig entry in
> a file reachable by all architectures. Say, in init/Kconfig or in
> drivers/tty/serial/Kconfig.
>
> (You can also have an entry for HAVE_EARLY_PCI for each arch that needs
> it, but that would be a bit silly.)
>
The HAVE_EARLY_PCI entry should be actually in generic PCI layer,
i.e. drivers/pci, because it's a PCI feature but only some archs
(currently only x86) support it.
Then an arch with this feature could announce it in arch/<arch>/Kconfig by:
select HAVE_EARLY_PCI if PCI
next prev parent reply other threads:[~2015-05-20 17:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-18 21:21 [PATCH v3 1/2] serial_core: add pci uart early console support Bin Gao
2015-05-19 12:01 ` Paul Bolle
2015-05-19 17:32 ` Bin Gao
2015-05-20 9:16 ` Paul Bolle
2015-05-20 17:59 ` Bin Gao [this message]
2015-05-20 17:50 ` Paul Bolle
2015-05-20 21:11 ` Bin Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150520175922.GA163133@worksta \
--to=bin.gao@linux.intel.com \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=pebolle@tiscali.nl \
--cc=peter@hurleysoftware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).