Re: [PATCH] tty: serial: omap: use mctrl_gpio helpers

[Tony Lindgren <tony@atomide.com>]

* Felipe Balbi <balbi@ti.com> [150522 10:41]:
> On Fri, May 22, 2015 at 09:52:13AM -0700, Tony Lindgren wrote:
> > * Nishanth Menon <nm@ti.com> [150522 08:36]:
> > > On 05/22/2015 07:16 AM, yegorslists@googlemail.com wrote:
> > > > From: Yegor Yefremov <yegorslists@googlemail.com>
> > > > 
> > > > This patch permits to use GPIOs to control the CTS/RTS/DTR/DSR/DCD/RI
> > > > signals.
> > > > 
> > > > Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
> > > > ---
> > > >  .../devicetree/bindings/serial/omap_serial.txt     |    9 +
> > > >  drivers/tty/serial/Kconfig                         |    1 +
> > > >  drivers/tty/serial/omap-serial.c                   |  168 +++++++++++++++++++-
> > > >  3 files changed, 171 insertions(+), 7 deletions(-)
> > > 
> > > Would we rather move introducing new features to 8250_omap.c rather
> > > than doing that to omap-serial and keep feature creeping it such that
> > > we wont ever be able to switch to 8250_omap ?
> > 
> > Yes please. Also, do we really want to allow mapping
> > random GPIO pins to the UART driver? I guess it would be
> 
> See drivers/tty/serial/serial_mctrl_gpio.[ch], these are used for UARTs
> on SoCs with enough GPIOs available whose UART don't have full Modem
> signals. It's pretty handy for BT, GSM, LTE, whatever type of modem-like
> device.

OK

Tony