public inbox for linux-serial@vger.kernel.org
 help / color / mirror / Atom feed
From: Felipe Balbi <balbi@ti.com>
To: Tony Lindgren <tony@atomide.com>
Cc: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
	Alan Stern <stern@rowland.harvard.edu>,
	Andreas Fenkart <afenkart@gmail.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Felipe Balbi <balbi@ti.com>,
	Huiquan Zhong <huiquan.zhong@intel.com>,
	Kevin Hilman <khilman@kernel.org>, NeilBrown <neilb@suse.de>,
	Mika Westerberg <mika.westerberg@linux.intel.com>,
	Nishanth Menon <nm@ti.com>,
	Peter Hurley <peter@hurleysoftware.com>,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-serial@vger.kernel.org, linux-omap@vger.kernel.org,
	Stephen Rothwell <sfr@canb.auug.org.au>
Subject: Re: [PATCH] PM / Wakeirq: Fix typo in prototype for dev_pm_set_dedicated_wake_irq
Date: Fri, 29 May 2015 12:18:37 -0500	[thread overview]
Message-ID: <20150529171837.GI2026@saruman.tx.rr.com> (raw)
In-Reply-To: <1432918442-2043-1-git-send-email-tony@atomide.com>

[-- Attachment #1: Type: text/plain, Size: 1226 bytes --]

On Fri, May 29, 2015 at 09:54:02AM -0700, Tony Lindgren wrote:
> Looks like I only built test the dev_pm_set_wake_irq and not the
> dev_pm_set_dedicated_wake_irq case on x86.
> 
> Turns out there's a typo for the dev_pm_set_dedicated_wake_irq
> prototype that causes a build error if CONFIG_COMPILE_TEST
> and CONFIG_MMC_OMAP_HS are selected.
> 
> Cc: Stephen Rothwell <sfr@canb.auug.org.au>
> Cc: Ulf Hansson <ulf.hansson@linaro.org>
> Reported-by: Jim Davis <jim.epost@gmail.com>
> Signed-off-by: Tony Lindgren <tony@atomide.com>

cool:

Reviewed-by: Felipe Balbi <balbi@ti.com>

> ---
>  include/linux/pm_wakeirq.h | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/include/linux/pm_wakeirq.h b/include/linux/pm_wakeirq.h
> index 4046fa1..cd5b62d 100644
> --- a/include/linux/pm_wakeirq.h
> +++ b/include/linux/pm_wakeirq.h
> @@ -30,8 +30,7 @@ static inline int dev_pm_set_wake_irq(struct device *dev, int irq)
>  	return 0;
>  }
>  
> -static inline int dev_pm_set_dedicated__wake_irq(struct device *dev,
> -						 int irq)
> +static inline int dev_pm_set_dedicated_wake_irq(struct device *dev, int irq)
>  {
>  	return 0;
>  }
> -- 
> 2.1.4
> 

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  reply	other threads:[~2015-05-29 17:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-29 16:54 [PATCH] PM / Wakeirq: Fix typo in prototype for dev_pm_set_dedicated_wake_irq Tony Lindgren
2015-05-29 17:18 ` Felipe Balbi [this message]
2015-05-30  1:16   ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150529171837.GI2026@saruman.tx.rr.com \
    --to=balbi@ti.com \
    --cc=afenkart@gmail.com \
    --cc=bigeasy@linutronix.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=huiquan.zhong@intel.com \
    --cc=khilman@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=mika.westerberg@linux.intel.com \
    --cc=neilb@suse.de \
    --cc=nm@ti.com \
    --cc=peter@hurleysoftware.com \
    --cc=rafael.j.wysocki@intel.com \
    --cc=sfr@canb.auug.org.au \
    --cc=stern@rowland.harvard.edu \
    --cc=tglx@linutronix.de \
    --cc=tony@atomide.com \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox