public inbox for linux-serial@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] PM / Wakeirq: Fix typo in prototype for dev_pm_set_dedicated_wake_irq
@ 2015-05-29 16:54 Tony Lindgren
  2015-05-29 17:18 ` Felipe Balbi
  0 siblings, 1 reply; 3+ messages in thread
From: Tony Lindgren @ 2015-05-29 16:54 UTC (permalink / raw)
  To: Rafael J. Wysocki, Alan Stern
  Cc: Andreas Fenkart, Greg Kroah-Hartman, Felipe Balbi, Huiquan Zhong,
	Kevin Hilman, NeilBrown, Mika Westerberg, Nishanth Menon,
	Peter Hurley, Sebastian Andrzej Siewior, Ulf Hansson,
	Thomas Gleixner, linux-pm, linux-kernel, linux-serial, linux-omap,
	Stephen Rothwell

Looks like I only built test the dev_pm_set_wake_irq and not the
dev_pm_set_dedicated_wake_irq case on x86.

Turns out there's a typo for the dev_pm_set_dedicated_wake_irq
prototype that causes a build error if CONFIG_COMPILE_TEST
and CONFIG_MMC_OMAP_HS are selected.

Cc: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Ulf Hansson <ulf.hansson@linaro.org>
Reported-by: Jim Davis <jim.epost@gmail.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>
---
 include/linux/pm_wakeirq.h | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/include/linux/pm_wakeirq.h b/include/linux/pm_wakeirq.h
index 4046fa1..cd5b62d 100644
--- a/include/linux/pm_wakeirq.h
+++ b/include/linux/pm_wakeirq.h
@@ -30,8 +30,7 @@ static inline int dev_pm_set_wake_irq(struct device *dev, int irq)
 	return 0;
 }
 
-static inline int dev_pm_set_dedicated__wake_irq(struct device *dev,
-						 int irq)
+static inline int dev_pm_set_dedicated_wake_irq(struct device *dev, int irq)
 {
 	return 0;
 }
-- 
2.1.4


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] PM / Wakeirq: Fix typo in prototype for dev_pm_set_dedicated_wake_irq
  2015-05-29 16:54 [PATCH] PM / Wakeirq: Fix typo in prototype for dev_pm_set_dedicated_wake_irq Tony Lindgren
@ 2015-05-29 17:18 ` Felipe Balbi
  2015-05-30  1:16   ` Rafael J. Wysocki
  0 siblings, 1 reply; 3+ messages in thread
From: Felipe Balbi @ 2015-05-29 17:18 UTC (permalink / raw)
  To: Tony Lindgren
  Cc: Rafael J. Wysocki, Alan Stern, Andreas Fenkart,
	Greg Kroah-Hartman, Felipe Balbi, Huiquan Zhong, Kevin Hilman,
	NeilBrown, Mika Westerberg, Nishanth Menon, Peter Hurley,
	Sebastian Andrzej Siewior, Ulf Hansson, Thomas Gleixner, linux-pm,
	linux-kernel, linux-serial, linux-omap, Stephen Rothwell

[-- Attachment #1: Type: text/plain, Size: 1226 bytes --]

On Fri, May 29, 2015 at 09:54:02AM -0700, Tony Lindgren wrote:
> Looks like I only built test the dev_pm_set_wake_irq and not the
> dev_pm_set_dedicated_wake_irq case on x86.
> 
> Turns out there's a typo for the dev_pm_set_dedicated_wake_irq
> prototype that causes a build error if CONFIG_COMPILE_TEST
> and CONFIG_MMC_OMAP_HS are selected.
> 
> Cc: Stephen Rothwell <sfr@canb.auug.org.au>
> Cc: Ulf Hansson <ulf.hansson@linaro.org>
> Reported-by: Jim Davis <jim.epost@gmail.com>
> Signed-off-by: Tony Lindgren <tony@atomide.com>

cool:

Reviewed-by: Felipe Balbi <balbi@ti.com>

> ---
>  include/linux/pm_wakeirq.h | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/include/linux/pm_wakeirq.h b/include/linux/pm_wakeirq.h
> index 4046fa1..cd5b62d 100644
> --- a/include/linux/pm_wakeirq.h
> +++ b/include/linux/pm_wakeirq.h
> @@ -30,8 +30,7 @@ static inline int dev_pm_set_wake_irq(struct device *dev, int irq)
>  	return 0;
>  }
>  
> -static inline int dev_pm_set_dedicated__wake_irq(struct device *dev,
> -						 int irq)
> +static inline int dev_pm_set_dedicated_wake_irq(struct device *dev, int irq)
>  {
>  	return 0;
>  }
> -- 
> 2.1.4
> 

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] PM / Wakeirq: Fix typo in prototype for dev_pm_set_dedicated_wake_irq
  2015-05-29 17:18 ` Felipe Balbi
@ 2015-05-30  1:16   ` Rafael J. Wysocki
  0 siblings, 0 replies; 3+ messages in thread
From: Rafael J. Wysocki @ 2015-05-30  1:16 UTC (permalink / raw)
  To: balbi
  Cc: Tony Lindgren, Rafael J. Wysocki, Alan Stern, Andreas Fenkart,
	Greg Kroah-Hartman, Huiquan Zhong, Kevin Hilman, NeilBrown,
	Mika Westerberg, Nishanth Menon, Peter Hurley,
	Sebastian Andrzej Siewior, Ulf Hansson, Thomas Gleixner, linux-pm,
	linux-kernel, linux-serial, linux-omap, Stephen Rothwell

On Friday, May 29, 2015 12:18:37 PM Felipe Balbi wrote:
> 
> --2fjX3cMESU3XgGmZ
> Content-Type: text/plain; charset=us-ascii
> Content-Disposition: inline
> Content-Transfer-Encoding: quoted-printable
> 
> On Fri, May 29, 2015 at 09:54:02AM -0700, Tony Lindgren wrote:
> > Looks like I only built test the dev_pm_set_wake_irq and not the
> > dev_pm_set_dedicated_wake_irq case on x86.
> >=20
> > Turns out there's a typo for the dev_pm_set_dedicated_wake_irq
> > prototype that causes a build error if CONFIG_COMPILE_TEST
> > and CONFIG_MMC_OMAP_HS are selected.
> >=20
> > Cc: Stephen Rothwell <sfr@canb.auug.org.au>
> > Cc: Ulf Hansson <ulf.hansson@linaro.org>
> > Reported-by: Jim Davis <jim.epost@gmail.com>
> > Signed-off-by: Tony Lindgren <tony@atomide.com>
> 
> cool:
> 
> Reviewed-by: Felipe Balbi <balbi@ti.com>

Applied, thanks!


-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-05-30  1:16 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-29 16:54 [PATCH] PM / Wakeirq: Fix typo in prototype for dev_pm_set_dedicated_wake_irq Tony Lindgren
2015-05-29 17:18 ` Felipe Balbi
2015-05-30  1:16   ` Rafael J. Wysocki

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox