From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Kroah-Hartman Subject: Re: [PATCH 1/2] pci_ids: Add Pericom vendor and device ids Date: Sun, 2 Aug 2015 22:14:16 -0700 Message-ID: <20150803051416.GA14585@kroah.com> References: <1438576401-24921-1-git-send-email-adam.lee@canonical.com> <20150803043647.GA20605@kroah.com> <20150803044428.GD19820@adam-laptop> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20150803044428.GD19820@adam-laptop> Sender: linux-pci-owner@vger.kernel.org To: Adam Lee Cc: linux-pci@vger.kernel.org, linux-serial@vger.kernel.org, Bjorn Helgaas List-Id: linux-serial@vger.kernel.org On Mon, Aug 03, 2015 at 12:44:28PM +0800, Adam Lee wrote: > On Sun, Aug 02, 2015 at 09:36:47PM -0700, Greg Kroah-Hartman wrote: > > On Mon, Aug 03, 2015 at 12:33:20PM +0800, Adam Lee wrote: > > > This patch add Pericom's vendor id and Pericom PI7C9X795[1248] chips' > > > device ids. > > > > > > Signed-off-by: Adam Lee > > > --- > > > include/linux/pci_ids.h | 6 ++++++ > > > 1 file changed, 6 insertions(+) > > > > > > diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h > > > index fcff8f8..c4a93cf 100644 > > > --- a/include/linux/pci_ids.h > > > +++ b/include/linux/pci_ids.h > > > @@ -2995,4 +2995,10 @@ > > > > > > #define PCI_VENDOR_ID_OCZ 0x1b85 > > > > > > +#define PCI_VENDOR_ID_PERICOM 0x12D8 > > > +#define PCI_DEVICE_ID_PERICOM_PI7C9X7951 0x7951 > > > +#define PCI_DEVICE_ID_PERICOM_PI7C9X7952 0x7952 > > > +#define PCI_DEVICE_ID_PERICOM_PI7C9X7954 0x7954 > > > +#define PCI_DEVICE_ID_PERICOM_PI7C9X7958 0x7958 > > > > Please read the top of this file, this isn't needed... > > > > thanks, > > > > greg k-h > > Oops. Pericom also has other products than serial card, so is it OK if I > still leave PCI_VENDOR_ID_PERICOM in pci_ids.h and move device ids to > particular driver? Thanks. Until it's needed, I wouldn't recommend added anything to pci_ids.h