From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Timur Tabi <timur@codeaurora.org>
Cc: peter@hurleysoftware.com, andre.przywara@arm.com,
Linus Walleij <linus.walleij@linaro.org>,
Andrew.Jackson@arm.com, linux-serial@vger.kernel.org,
Greg Kroah-Hartman <greg@kroah.com>,
jslaby@suse.com, jun.nie@linaro.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] serial: amba-pl011: abstract register accessors
Date: Tue, 3 Nov 2015 16:12:07 +0000 [thread overview]
Message-ID: <20151103161206.GA8644@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1446562867-5693-2-git-send-email-timur@codeaurora.org>
On Tue, Nov 03, 2015 at 09:01:07AM -0600, Timur Tabi wrote:
> Finally, note that pl011_putc() is untouched, because that function
> does not have access to the 'uap' object. A separate mechanism
> is needed to switch accessors in that function.
Thanks for pointing that out... that's a mistake in my patches. It's
very difficult to see how we could ever support earlyconsole on ZTE
without massively overhauling the earlycon stuff. I'll undo the
changes there in my series.
Now, as for this patch...
> unsigned int (*get_fifosize)(struct amba_device *dev);
> + u16 (*regreadw)(const void __iomem *addr);
> + void (*regwritew)(u16 val, void __iomem *addr);
> + void (*regwriteb)(u8 val, void __iomem *addr);
regwriteb() is used nowhere in this patch.
--
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
next prev parent reply other threads:[~2015-11-03 16:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-03 15:01 [PATCH 1/2] serial: amba-pl011: use cpu_relax when polling registers Timur Tabi
2015-11-03 15:01 ` [PATCH 2/2] serial: amba-pl011: abstract register accessors Timur Tabi
2015-11-03 16:12 ` Russell King - ARM Linux [this message]
2015-11-03 16:43 ` Timur Tabi
2015-11-06 1:19 ` Peter Hurley
2015-11-06 1:14 ` [PATCH 1/2] serial: amba-pl011: use cpu_relax when polling registers Peter Hurley
2015-12-13 6:04 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151103161206.GA8644@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=Andrew.Jackson@arm.com \
--cc=andre.przywara@arm.com \
--cc=greg@kroah.com \
--cc=jslaby@suse.com \
--cc=jun.nie@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-serial@vger.kernel.org \
--cc=peter@hurleysoftware.com \
--cc=timur@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).