From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: LABBE Corentin <clabbe.montjoie@gmail.com>
Cc: gregkh@linuxfoundation.org, jslaby@suse.com,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH v2 1/1] serial: imx: fix a possible NULL dereference
Date: Sun, 29 Nov 2015 18:03:03 +0100 [thread overview]
Message-ID: <20151129170303.GD10431@pengutronix.de> (raw)
In-Reply-To: <1448375817-16189-2-git-send-email-clabbe.montjoie@gmail.com>
On Tue, Nov 24, 2015 at 03:36:57PM +0100, LABBE Corentin wrote:
> of_match_device could return NULL, and so cause a NULL pointer
> dereference later.
> Even if the probability of this case is very low, fixing it made
> static analyzers happy.
> Solving this with of_device_get_match_data made also code simplier.
>
> Signed-off-by: LABBE Corentin <clabbe.montjoie@gmail.com>
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Thanks
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
prev parent reply other threads:[~2015-11-29 17:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-24 14:36 [PATCH v2 0/1] serial: imx: fix a possible NULL dereference LABBE Corentin
2015-11-24 14:36 ` [PATCH v2 1/1] " LABBE Corentin
2015-11-29 17:03 ` Uwe Kleine-König [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151129170303.GD10431@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=clabbe.montjoie@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).